Skip to content

Conversation

sungwoncho
Copy link

I'd like to add dnote, a command line notebook. It has been maintaining its own tap (https://github.com/dnote/homebrew-dnote/) since 2017 and users preferred the official tap.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide? - Commit message dnote 0.15.2 (new formula) matches required format
  • Have you checked that there aren't other open pull requests for the same formula update/change? - No existing commit.
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
▶ HOMEBREW_NO_INSTALL_FROM_API=1 /home/linuxbrew/.linuxbrew/bin/brew install --build-from-source dnote
==> Fetching downloads for: dnote
==> Fetching dnote/dnote/dnote
==> Downloading https://github.com/dnote/dnote/archive/refs/tags/cli-v0.15.2.tar.gz
==> Downloading from https://codeload.github.com/dnote/dnote/tar.gz/refs/tags/cli-v0.15.2
        -=O=- #         #          #            #                                                                                                                                                                    
==> Installing dnote from dnote/dnote
==> go build -ldflags=-s -w -X main.apiEndpoint=http://localhost:3000/api -X main.versionTag=0.15.2 -tags fts5 ./pkg/cli
🍺  /home/linuxbrew/.linuxbrew/Cellar/dnote/0.15.2: 7 files, 8.9MB, built in 1 minute 3 seconds
==> Running `brew cleanup dnote`...
Disable this behaviour by setting `HOMEBREW_NO_INSTALL_CLEANUP=1`.
Hide these hints with `HOMEBREW_NO_ENV_HINTS=1` (see `man brew`).
==> No outdated dependents to upgrade!
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
▶ /home/linuxbrew/.linuxbrew/bin/brew test dnote                                                      
Warning: test is a developer command, so Homebrew's
developer mode has been automatically turned on.
To turn developer mode off, run:
  brew developer off

==> Installing 'bundler' gem
Fetching bundler-2.6.8.gem
Fetching gem metadata from https://rubygems.org/.......
Fetching public_suffix 6.0.2
Fetching base64 0.3.0
Fetching bindata 2.5.1
Fetching concurrent-ruby 1.3.5
Installing base64 0.3.0
Fetching minitest 5.25.5
Installing public_suffix 6.0.2
Fetching plist 3.7.2
Installing bindata 2.5.1
Fetching ruby-macho 4.1.0
Installing concurrent-ruby 1.3.5
Fetching sorbet-runtime 0.6.12578
Installing minitest 5.25.5
Fetching warning 1.5.0
Installing plist 3.7.2
Fetching addressable 2.8.7
Installing ruby-macho 4.1.0
Fetching elftools 1.3.1
Installing sorbet-runtime 0.6.12578
Installing warning 1.5.0
Installing addressable 2.8.7
Installing elftools 1.3.1
Fetching patchelf 1.5.1
Installing patchelf 1.5.1
Bundle complete! 43 Gemfile dependencies, 13 gems now installed.
Bundled gems are installed into `../../../linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle`
==> Testing dnote/dnote/dnote
==> /home/linuxbrew/.linuxbrew/Cellar/dnote/0.15.2/bin/dnote version
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Yes.

▶/home/linuxbrew/.linuxbrew/bin/brew audit --new dnote

▶ /home/linuxbrew/.linuxbrew/bin/brew audit --strict dnote                                            


@github-actions github-actions bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Oct 6, 2025
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

Copy link
Member

@botantony botantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you can fix the test error by changing ENV["HOME"] to testpath/".home/brew" or something like that

Simple command line notebook for programmers
@daeho-ro daeho-ro added the ready to merge PR can be merged once CI is green label Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants