Skip to content

aws-auth: add warning that upstream repo has new owner #247002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2025
Merged

aws-auth: add warning that upstream repo has new owner #247002

merged 2 commits into from
Oct 6, 2025

Conversation

Firefishy
Copy link
Contributor

Added warning about GitHub repo ownership changed.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@Firefishy
aws-auth: add warning that upstream repo has new owner
2164111 
Added warning about GitHub repo ownership changed.
@github-actions github-actions bot added nodejs Node or npm use is a significant feature of the PR or issue formula deprecated Formula deprecated labels Oct 6, 2025
SMillerDev
SMillerDev reviewed Oct 6, 2025
View reviewed changes
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the better option is just to disable the formula

@SMillerDev
aws-auth: disable
28154de 
Updated homepage link and deprecation notice.
@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. formula disabled Formula disabled labels Oct 6, 2025
@Firefishy
Copy link
Contributor Author

Thank you. Looks good to me, but I'd still recommend text in the forumla to explain the reason. I guess people may discover this PR.

@SMillerDev SMillerDev enabled auto-merge October 6, 2025 12:19
@SMillerDev SMillerDev added this pull request to the merge queue Oct 6, 2025
Merged via the queue into Homebrew:main with commit f3d2ac5 Oct 6, 2025
25 of 26 checks passed
@Firefishy Firefishy deleted the patch-1 branch October 6, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

@botantony botantony botantony approved these changes

Assignees
No one assigned
Labels
autosquash Automatically squash pull request commits according to Homebrew style. formula deprecated Formula deprecated formula disabled Formula disabled nodejs Node or npm use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Firefishy @SMillerDev @botantony