Skip to content

fix: isolate VGUI browser input ownership - #13

Merged
Hona merged 1 commit into
mainfrom
fix/vgui-keyboard-event-ownership
Jul 21, 2026
Merged

Hona merged 1 commit into
mainfrom
fix/vgui-keyboard-event-ownership

Conversation

@Hona

@Hona Hona commented Jul 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • ignore document keyboard, text-input, and IME events whose target is outside the owning VGUI host
  • require input events to target the exact panel DOM node instead of trusting a reusable numeric panel ID
  • preserve native Space and Backspace editing in the independent developer-console input
  • track and document the browser-event ownership contract

Verification

  • bun test (311 pass)
  • bun test packages/presentation/vgui/tests (77 pass)
  • bun test apps/web/tf2/tests (23 pass)
  • bun run --cwd apps/web/tf2 build

Copilot AI review requested due to automatic review settings July 21, 2026 09:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Hona
Hona merged commit cc1510a into main Jul 21, 2026
1 check passed
@Hona
Hona deleted the fix/vgui-keyboard-event-ownership branch July 21, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants