Add HTMLButtonElement interface to custom element test #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyu3x
force-pushed
the
add-custom-element-button
branch
6 times, most recently
from
cea39f6
to
cef1df4
Compare
Honry
reviewed
Mar 21, 2018
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <title>Custom Elements: CEReactions on Element interface</title> |
There was a problem hiding this comment.
Element has been replaced.
| @@ -0,0 +1,114 @@ | |||
| <!DOCTYPE html> | |||
| <html> | |||
| <head> | |||
There was a problem hiding this comment.
head, html, body labels are unnecessary.
There was a problem hiding this comment.
Labels head and html have been omitted.
| <body> | ||
| <script> | ||
|
|
||
| //IDL attribute reflects the content attribute of the same name inside the parent Node |
There was a problem hiding this comment.
Actually I can't understand the comments.
There was a problem hiding this comment.
Notes are updated.
| } | ||
|
|
||
| //IDL attribute reflects the content attribute of the same name which depends another attribute inside the parent Node | ||
| function testReflectAttributeWithDepAttributeWithContentValues(subJsAttrName, subConAttrName, depAttrName, subJsAttrValue1, subConAttrValue1, subJsAttrValue2, subConAttrValue2, depAttrValue, name, subElementName, pareElementName, interfaceName) { |
There was a problem hiding this comment.
The name is cutted
xiaoyu3x
force-pushed
the
add-custom-element-button
branch
from
cef1df4
to
58fba0d
Compare
Honry
reviewed
Mar 21, 2018
| <script src="/tests/custom-elements/resources/testharness.js"></script> | ||
| <script src="/tests/custom-elements/resources/testharnessreport.js"></script> | ||
| <script src="./custom-elements-helpers.js"></script> | ||
| <script src="./reactions.js"></script> |
There was a problem hiding this comment.
'./' has been removed.
|
|
||
| //In parent node, sub node's observeAttribute can enqueue by changing attribute value | ||
| //Re->reflect, At->attribute, P->parent, Co->content | ||
| function testReAtWithPNodeWithCoValues(jsAtName, coAtName, jsAtValue1, coAtValue1, jsAtValue2, coAtValue2, name, elementName, pElementName, interfaceName) { |
There was a problem hiding this comment.
How about testReflectAttrWithContentValuesAndPNode? And replace the second line of comment with "Test reflect attribute with content values and parent node", not sure if I am right.
There was a problem hiding this comment.
Your suggestion is good, I has updated.
| parentElement.parentNode.removeChild(parentElement); | ||
| } | ||
|
|
||
| //Package JS attribute with parent Node to test |
| } | ||
|
|
||
| //In parent node, sub node's observeAttribute which depends another attribute can enqueue by changing attribute value | ||
| //Re->reflect, At->attribute, De->depdent, Co->content |
| parentElement.parentNode.removeChild(parentElement); | ||
| } | ||
|
|
||
| //Package JS attribute depends another atrribute |
| testReAtWithDeAtWithCoValues(jsAtName, coAtName, deAtName, jsAtValue1, jsAtValue1, jsAtValue2, jsAtValue2, deAtValue, name, elementName, pElementName, interfaceName); | ||
| } | ||
|
|
||
| testReflectAttributeWithContentValues('autofocus', 'autofocus', true, 'true', false, 'false', 'autofocus on HTMLButtonElement', 'button', HTMLButtonElement); |
There was a problem hiding this comment.
move following test function calls to the beginning of <script>
There was a problem hiding this comment.
Move function calls to the beginning of <script>
xiaoyu3x
force-pushed
the
add-custom-element-button
branch
from
58fba0d
to
56efcb3
Compare
Honry
reviewed
Mar 21, 2018
| @@ -0,0 +1,112 @@ | |||
| <!DOCTYPE html> | |||
| <title>Custom Elements: CEReactions on HTMLButtonElement interface</title> | |||
| <meta name="author" title="Zhang xiaoyu" href="[email protected]"> | |||
|
|
||
| //In parent node, sub node's observeAttribute can enqueue by changing attribute value | ||
| //Test reflect attribute with content values and parent node | ||
| function testReAtWithPNodeWithCoValues(jsAtName, coAtName, jsAtValue1, coAtValue1, jsAtValue2, coAtValue2, name, elementName, pElementName, interfaceName) { |
There was a problem hiding this comment.
You didn't update the function name.
There was a problem hiding this comment.
The function name has been updated
| } | ||
|
|
||
| //Package refect attribute with parent Node | ||
| function testReAtWithPNode(jsAtName, coAtName, jsAtValue1, jsAtValue2, name, elementName, pElementName, interfaceName) { |
|
|
||
| //In parent node, sub node's observeAttribute which depends another attribute can enqueue by changing attribute value | ||
| //Test reflect attribute with content values and dependent attribute | ||
| function testReAtWithDeAtWithCoValues(jsAtName, coAtName, deAtName, jsAtValue1, coAtValue1, jsAtValue2, coAtValue2, deAtValue, name, elementName, pElementName, interfaceName) { |
|
|
||
| test(() => { | ||
| var element = define_build_in_custom_element([coAtName], interfaceName, elementName); | ||
| var instance = document.createElement(elementName, { is: element.name}); |
There was a problem hiding this comment.
need whitespace after element.name
There was a problem hiding this comment.
Whitespace has updated
| } | ||
|
|
||
| //Package reflect attribute with dependent attribute | ||
| function testReAtWithDeAt(jsAtName, coAtName, deAtName, jsAtValue1, jsAtValue2, deAtValue, name, elementName, pElementName, interfaceName) { |
xiaoyu3x
force-pushed
the
add-custom-element-button
branch
from
56efcb3
to
a6176f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All attributes use built-in way