🧹 refactor: Replace eslint disable with unused variable convention#22
Merged
Shreyassp002 merged 1 commit intomainfrom Apr 6, 2026
Merged
Conversation
…derscore Co-authored-by: Shreyassp002 <96625037+Shreyassp002@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
⚡ Flash Review
✅ This PR looks clean. No security issues, bugs, or significant improvements found. ⚡ Powered by Flash Review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What: Removed the
// eslint-disable-next-line @typescript-eslint/no-unused-varscomment and aliased thepayment_linksproperty to_payment_linksduring object destructuring insrc/app/api/transactions/[id]/route.ts.💡 Why: This leverages TypeScript/ESLint conventions allowing unused variables to be prefixed with an underscore to ignore them, eliminating the need for inline ESLint disable comments.
✅ Verification: Verified by executing
npm run lintandnpm run test, ensuring no linting issues remain for this variable and tests are still passing.✨ Result: Improved codebase cleanliness and maintainability by utilizing standard patterns over suppression comments.
PR created automatically by Jules for task 873320628204842608 started by @Shreyassp002