-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide all text state operators #1216
Open
retfah
wants to merge
8
commits into
Hopding:master
Choose a base branch
from
retfah:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Apr 12, 2022
-
additional options for drawing text
Provide textRenderingMode, horizontalScaling, textRise, charcterSpacing and wordSpacing as an option for drawing text. In operator.ts and PDFOperatorNames.ts those operators were already implementes. The function for the horizontalScaling (as it is called in the pdf standard) was called "setCharacterSqueeze" so far. To keep the standardized terminology, the function was renamed to "setHorizontalSpacing". However, for backward compatibility (if somebody had used setCharacterSqueeze in his own script; in the actual pdf-lib code there was no reference) the original function was kept as well with a deprecated note. In the textOptions, not the standard names were used, but noun forms of it, to match the current options style (e.g. horizontalScale (options) instead of horizontalScaling (pdf standard)).
Configuration menu - View commit details
-
Copy full SHA for 39386a8 - Browse repository at this point
Copy the full SHA 39386a8View commit details -
Revert "additional options for drawing text"
This reverts commit 39386a8.
Configuration menu - View commit details
-
Copy full SHA for ba77412 - Browse repository at this point
Copy the full SHA ba77412View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79a4868 - Browse repository at this point
Copy the full SHA 79a4868View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42c9739 - Browse repository at this point
Copy the full SHA 42c9739View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30b588d - Browse repository at this point
Copy the full SHA 30b588dView commit details -
the first commit in master had to be reverted, since the tests were still in a temporary modified state. A new branch (textOptions) was then created on the basis of the meanwhile reverted commit. In this branch, the tests were cleaned up and the branch finally got merged with tha master. However, the actual changes, which were reverted in the master, were not merged, despiute the fact they were present in the brach. Finally, I manually added the actual changes directly in the master.
Configuration menu - View commit details
-
Copy full SHA for 50699e9 - Browse repository at this point
Copy the full SHA 50699e9View commit details
Commits on Apr 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for aed4aac - Browse repository at this point
Copy the full SHA aed4aacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7829e2b - Browse repository at this point
Copy the full SHA 7829e2bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.