New PoseidonHash/RAMT/SMT #33

DanieleDiBenedetto · 2020-06-25T09:51:20Z

Closes #14 and also #39

DanieleDiBenedetto · 2020-06-25T09:51:54Z

api/Cargo.toml

-algebra = {version = "0.1.0", git = "https://github.com/ZencashOfficial/ginger-lib.git", branch = "development"}
-primitives = {version = "0.1.0", features = ["merkle_tree", "signature", "vrf"], git = "https://github.com/ZencashOfficial/ginger-lib.git", branch = "development"}
-proof-systems = {version = "0.1.0", features = ["groth16"], git = "https://github.com/ZencashOfficial/ginger-lib.git", branch = "development"}
+algebra = {version = "0.1.0", git = "https://github.com/ZencashOfficial/ginger-lib.git", branch = "updatable_poseidon"}


Once UpdatablePoseidon branch will be merged in GingerLib we must change this dependency.

DanieleDiBenedetto · 2020-06-25T09:52:19Z

demo-circuit/Cargo.toml

-r1cs-core = {version = "0.1.0", git = "https://github.com/ZencashOfficial/ginger-lib.git", branch = "development"}
-r1cs-std = {version = "0.1.0", git = "https://github.com/ZencashOfficial/ginger-lib.git", branch = "development"}
-proof-systems = {version = "0.1.0", features = ["groth16"], git = "https://github.com/ZencashOfficial/ginger-lib.git", branch = "development"}
+algebra = {version = "0.1.0", git = "https://github.com/ZencashOfficial/ginger-lib.git", branch = "updatable_poseidon"}


Once UpdatablePoseidon branch will be merged in GingerLib we must change this dependency.

DanieleDiBenedetto · 2020-06-25T09:52:31Z

ouroboros/Cargo.toml

@@ -5,7 +5,7 @@ authors = ["DanieleDiBenedetto <[email protected]>"]
 edition = "2018"

 [dependencies]
-algebra = {version = "0.1.0", git = "https://github.com/ZencashOfficial/ginger-lib.git", branch = "development"}
-primitives = {version = "0.1.0", features = ["vrf"], git = "https://github.com/ZencashOfficial/ginger-lib.git", branch = "development"}
+algebra = {version = "0.1.0", git = "https://github.com/ZencashOfficial/ginger-lib.git", branch = "updatable_poseidon"}


Once UpdatablePoseidon branch will be merged in GingerLib we must change this dependency.

…al/zendoo-sc-cryptolib into updatable_poseidon

api/src/ginger_calls.rs

- Modified function signature 'RandomAccessMerkleTree.init(height)' to 'RandomAccessMerkleTree.init(height, processing_step)'; - Modified class name 'RandomAccessMerkleTree' to 'FieldBasedOptimizedMHT'; - Added possibility, for all Merkle Trees, to create a Merkle Path; - Introduced new MerklePath class containing a verify() function; - Modified, for all Merkle Trees, the relationship between height (h) and number of leaves (l). Previously it was l = 2^(h - 1) now it's l = 2^h; - Some useful refactoring; - Other minor changes to sync with GingerLib's 'smt' branch

jni/src/main/java/com/horizen/merkletreenative/BigLazyMerkleTree.java

i-Alex · 2020-09-15T10:28:09Z

jni/src/main/java/com/horizen/merkletreenative/BigMerkleTree.java

        return nativeGetPosition(leaf);
    }

    private native boolean nativeIsPositionEmpty(long position);

    public boolean isPositionEmpty(long position){
        if (merkleTreePointer == 0)
-            throw new IllegalArgumentException("merkleTreePointer must be not null.");
+            throw new IllegalArgumentException("BigMerkleTree instance was freed.");
        return nativeIsPositionEmpty(position);
    }

    private native void nativeAddLeaf(FieldElement leaf, long position);

    public void addLeaf(FieldElement leaf, long position){


So, what about this method? Are you going to remove position arg?

I'm not sure about this one. From an usage perspective can be misleading, but probably for testing and debugging it will be useful

jni/src/main/java/com/horizen/merkletreenative/InMemoryOptimizedMerkleTree.java

i-Alex · 2020-09-15T10:31:19Z

jni/src/main/java/com/horizen/merkletreenative/MerklePath.java

+        this.merklePathPointer = merklePathPointer;
+    }
+
+    private native boolean nativeVerify(int merkleTreeHeight, FieldElement leaf, FieldElement root);


Why do we need the merkleTreeHeight here? Is it not enough just to apply the path elements to the leaf one by one and then compare it with the root?

I want to check also that the path is of the correct length, otherwise I can just pass as a leaf a children of the root and the method will pass anyway.
As using the height as an explicit parameter, instead, is a result of keeping the height as a free parameter to instantiate the merkle trees. Hardcoding the height in the rust side of the cryptolib means that if we want to modify the height of a tree, we should release a new version of the cryptolib; or if a sidechain creator wants to declare a new tree, he has to modify explicitly the zendoo-sc-cryptolib too (even if, probably, he has to do it anyway)

…more appropriate

… Ginger last modifications

albertog78 · 2021-04-22T10:56:42Z

api/src/ginger_calls.rs

@@ -347,7 +391,12 @@ pub fn vrf_prove(msg: &FieldElement, sk: &VRFSk, pk: &VRFPk) -> Result<(VRFProof
    let mut hash_input = Vec::new();


are these 3 lines still needed?

albertog78 · 2021-04-22T11:04:34Z

api/src/ginger_calls.rs

+    ((1 + FIELD_SIZE) * path.get_length()) + 1
+}
+
+pub fn apply(path: &GingerMHTPath, leaf: &FieldElement) -> FieldElement


move to ginger-lib FieldBasedMHTPath

Updatable Poseidon Hash

c2b1d8e

DanieleDiBenedetto requested a review from albertog78 June 25, 2020 09:51

DanieleDiBenedetto commented Jun 25, 2020

View reviewed changes

DanieleDiBenedetto linked an issue Jun 25, 2020 that may be closed by this pull request

Poseidon Hash/RAMT/SMT #14

Closed

DanieleDiBenedetto added 7 commits June 26, 2020 13:13

Update to last version

4f6841f

Update to last hash/mht part 1

92201bc

Sync with ginger lib smt branch

c247511

Expose to Java BigMerkleTree implementations

43ccb70

Added some comments

3c87aee

MerkleTrees with tests. Java test not passing

522f4e5

Sync last changes in GingerLib's smt branch, i.e. SMT persistency

7199cd0

DanieleDiBenedetto marked this pull request as draft August 6, 2020 17:11

DanieleDiBenedetto added 6 commits August 6, 2020 13:19

Minor fixes

d442189

Other modifications

016a44e

Commented free for MTs

635f973

Fixed problem in Merkle Tree free functions

63a1620

Updated test

fb6fb61

Added persistency tests

e6a1781

DanieleDiBenedetto changed the title ~~Updatable Poseidon Hash~~ New PoseidonHash/RAMT/SMT Aug 24, 2020

DanieleDiBenedetto requested a review from i-Alex August 24, 2020 11:33

DanieleDiBenedetto marked this pull request as ready for review August 24, 2020 11:33

DanieleDiBenedetto requested a review from oaleksandrov-ip August 24, 2020 12:48

DanieleDiBenedetto and others added 6 commits August 24, 2020 14:51

Update README.md

e7bf915

Marked computePoseidonHash function as deprecated

fa8814b

Minor fix

bfdab99

Updated tests

28a9a9c

Update README.md

93c6051

Small fix

fa6d6a1

Merge branch 'updatable_poseidon' of https://github.com/HorizenOffici…

3309b86

…al/zendoo-sc-cryptolib into updatable_poseidon

i-Alex reviewed Aug 27, 2020

View reviewed changes

api/src/ginger_calls.rs Outdated Show resolved Hide resolved

api/src/ginger_calls.rs Outdated Show resolved Hide resolved

DanieleDiBenedetto added 2 commits August 28, 2020 04:18

Fix typo in return type of fn compute_pks_threshold_hash

4007a56

DanieleDiBenedetto requested a review from i-Alex September 11, 2020 13:12

Minor fix + comment

0f0d5d2

i-Alex suggested changes Sep 15, 2020

View reviewed changes

DanieleDiBenedetto and others added 5 commits September 16, 2020 08:53

Changed IllegalArgumentException to IllegalStateException where it's …

0958589

…more appropriate

Readme file updated: java jar compilation guide added.

530fd62

Update README.md

16f39fa

Update README.md

9cdcb00

New functions to MerklePath

164964e

DanieleDiBenedetto requested a review from i-Alex October 2, 2020 16:49

DanieleDiBenedetto linked an issue Oct 5, 2020 that may be closed by this pull request

Better explain the building process #39

Closed

DanieleDiBenedetto added 5 commits October 8, 2020 04:18

Refer to stable Ginger smt branch commit + getPosition static function

0302eaa

Removed fixed dependency

99ca602

Added temporary MerklePath.apply(leaf) function

dd2692d

Added temporary MerklePath.apply(leaf) function

d354f6b

Simplified and optimized SMTs initialization and loading according to…

c3cd073

… Ginger last modifications

i-Alex force-pushed the updatable_poseidon branch from 3f4eb61 to c3cd073 Compare March 18, 2021 09:28

albertog78 suggested changes Apr 22, 2021

View reviewed changes

DanieleDiBenedetto closed this Apr 22, 2021

DanieleDiBenedetto deleted the updatable_poseidon branch March 23, 2023 15:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New PoseidonHash/RAMT/SMT #33

New PoseidonHash/RAMT/SMT #33

DanieleDiBenedetto commented Jun 25, 2020 •

edited

Loading

DanieleDiBenedetto Jun 25, 2020

DanieleDiBenedetto Jun 25, 2020

DanieleDiBenedetto Jun 25, 2020

i-Alex Sep 15, 2020

DanieleDiBenedetto Sep 15, 2020

i-Alex Sep 15, 2020

DanieleDiBenedetto Sep 15, 2020 •

edited

Loading

albertog78 Apr 22, 2021

albertog78 Apr 22, 2021

		@@ -347,7 +391,12 @@ pub fn vrf_prove(msg: &FieldElement, sk: &VRFSk, pk: &VRFPk) -> Result<(VRFProof
		let mut hash_input = Vec::new();

New PoseidonHash/RAMT/SMT #33

New PoseidonHash/RAMT/SMT #33

Conversation

DanieleDiBenedetto commented Jun 25, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DanieleDiBenedetto Sep 15, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DanieleDiBenedetto commented Jun 25, 2020 •

edited

Loading

DanieleDiBenedetto Sep 15, 2020 •

edited

Loading