Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve svelte 5 documentation #1403

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Improve svelte 5 documentation #1403

merged 1 commit into from
Dec 16, 2024

Conversation

SeppahBaws
Copy link
Collaborator

I initially didn't think that the $derived would be necessary, since the graphql tags return a store, but it ends up being very important so that if they are ever reassigned with a new store, the UI updates accordingly.

I also improved the wording a little bit and added the exact versions from which Svelte 5 is supported.

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: 2d3282f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@SeppahBaws SeppahBaws enabled auto-merge (squash) December 12, 2024 13:13
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for houdini-docs-next ready!

Name Link
🔨 Latest commit 2d3282f
🔍 Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/675ae1746cf85a00089cd64d
😎 Deploy Preview https://deploy-preview-1403--houdini-docs-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for houdinigraphql ready!

Name Link
🔨 Latest commit 2d3282f
🔍 Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/675ae1740b927100085a0d27
😎 Deploy Preview https://deploy-preview-1403--houdinigraphql.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AlecAivazis AlecAivazis disabled auto-merge December 16, 2024 23:39
@AlecAivazis AlecAivazis enabled auto-merge (squash) December 16, 2024 23:39
@AlecAivazis AlecAivazis merged commit 807bb2b into main Dec 16, 2024
15 checks passed
@AlecAivazis AlecAivazis deleted the svelte-5-docs branch December 16, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants