Fix bug where JSON error response might get treated as non-JSON error response #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, if the server returns an NGINX error page, `defaultFetch` will still attempt to parse the response as JSON, which will throw a syntax error, which is harder to understand than something like `502: Bad Gateway`
The `content-type` header can have `charset` or `boundary` in it as well, so just make sure it starts with one of the valid content types instead of checking strict equality.
🦋 Changeset detectedLatest commit: 9892ef3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for houdinigraphql canceled.
|
✅ Deploy Preview for houdini-docs-next canceled.
|
Accidentally got included from the last PR I made, woops
SeppahBaws
requested changes
Jan 7, 2025
SeppahBaws
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # N/A
To help everyone out, please make sure your PR does the following:
pnpm run testsandcd integration && pnpm run testspnpm changesetThis PR fixes a bug from #1404 where valid
content-types would be treated as invalid because it checked that thecontent-typewas strictly equal to one of the valid values. However, thecontent-typeheader can have other stuff in it after the content type, (e.g.application/json; charset=utf-8) so just check that it starts with the right thing instead of checking equality.