fix: unassign roles on roster removal

Houston-ARTCC · Apr 9, 2024 · dddcf01 · dddcf01
1 parent 2cd140d
commit dddcf01
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/apps/resources/views.py b/apps/resources/views.py
@@ -25,7 +25,7 @@ def get(self, request):
 
         return Response(
             {
-                category.lower(): ResourceSerializer(resources, many=True).data
+                category: ResourceSerializer(resources, many=True).data
                 for category, resources in sorted_resources.items()
             }
         )

diff --git a/apps/users/models.py b/apps/users/models.py
@@ -194,9 +194,14 @@ def set_membership(self, short):
             return
 
         if short is None:
+            self.roles.clear()
+
             self.status = Status.NON_MEMBER
             self.endorsements = None
         else:
+            self.roles.remove(*self.roles.filter(short__in=["HC", "VC"]))
+            self.add_role(short)
+
             if self.status == Status.NON_MEMBER:
                 self.status = Status.ACTIVE
                 self.endorsements = default_endorsements()
@@ -213,9 +218,6 @@ def set_membership(self, short):
 
         self.save()
 
-        self.roles.remove(*self.roles.filter(short__in=["HC", "VC"]))
-        self.add_role(short)
-
     def update_loa_status(self):
         loa_filter = self.loas.filter(start__lt=date.today(), approved=True)