Add -unwind versions of the hooks.

[xNxExOx]

And remove unused use in src/arch/x86/trampoline/mod.rs,

[Hpmason]

Thanks for this PR. Based off the bit I've read, I appreciate reducing any UB in this crate. I haven't been following the nightly feature for this change, I was just wondering if you knew the status of it? Is this a feature that is coming in stable soon?

This is probably something we still want to put under a new feature flag (e.g. unwind-abis) just to keep a default lower MSRV. Plus, if it's gonna be a nightly for a longer or an unknown period of time, it'll also avoid breaking in new nightly versions for people who don't need to opt into it.

[xNxExOx]

Oh that is actually a good point, for the project where I use it I am (and will be 😢) on nightly, but I was under impression, that this reached stable many moths ago, but I did not really checked that.

It was merged in 2021: Implement RFC 2945: "C-unwind" ABI #76570 , so it exists for quite some time.

And it is available just fine on stable playground

The default behavior changed at some point between nightly-2024-05-01-i686-pc-windows-msvc and nightly-2024-09-01-i686-pc-windows-msvc, that *-unwind are required for C++ exceptions to not cause crash. This was one of the breaking changes I needed to fix, in order to successfully update.

I can easily gate changes in src/macros.rs, but I do not know, how to easily gate changes in src/arch/x86/mod.rs, without duplicating the functions.

[Hpmason]

Oh looks like the extern *-unwinds were added in 1.71 and finalized in 1.81 fully completed the transition (based off rust blog release notes). So it should be good to add without nightly.

I would still feature flag gate it since the MSRV of this crate is still 1.60. (I'll probably increase that in a newer crate release, but for now we can put it behind a feature.)

As for src/arch/x86/mod.rs, you can revert those changes since I think they only apply to tests, which they don't panic or call C++ code, so I don't see a big reason to update those tests or duplicate them.