fix: improve memory safety to prevent an OOB#76
Open
ggielly wants to merge 1 commit intoHpmason:masterfrom
Open
fix: improve memory safety to prevent an OOB#76ggielly wants to merge 1 commit intoHpmason:masterfrom
ggielly wants to merge 1 commit intoHpmason:masterfrom
Conversation
…out-of-bounds reads in build() - Ensure the target address is within an executable memory region
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The builder now queries the memory region of the target address to ensure it's executable and calculates the maximum number of bytes that can be safely read : this is preventing potential out-of-bounds memory access. If the region is not executable or too small, an appropriate error is returned.