-
Notifications
You must be signed in to change notification settings - Fork 5
Config Revamp #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
camden11
wants to merge
46
commits into
main
Choose a base branch
from
dynamic-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Config Revamp #231
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
cee8aac
config revamp WIP
camden11 b252721
finish getConfig
camden11 4595dc5
more config WIP
camden11 29d26ba
more config WIP
camden11 63b55fa
config wip
camden11 9ab3c88
-wip
camden11 7404320
update handling of env config
camden11 93c27be
Update accounts
camden11 d521932
config account adding/updating
camden11 fc6ca45
finish config exportable first pass
camden11 c715602
add back missing methods we might need
camden11 06669df
handle new environment variables
camden11 2492289
Add config source options to environment
camden11 258be5e
Cleanup wip
camden11 05699b3
Fix TS build
camden11 930ac75
remove unneeded types
camden11 b541617
configUtils tests
camden11 e415848
Config WIP
camden11 5cb2fa0
Finish tests for config
camden11 e85f998
Delete old tests
camden11 6ec40b3
update PAK tests
camden11 59152d2
Fix existing tests
camden11 c0cdc17
Add error and debug copy to new config methods
camden11 63bc4a2
Handle named default accounts
camden11 267b483
Add defaultAccountOverride functionality
camden11 2533194
return default account if exists
camden11 a236fa8
Fix tests
camden11 1a686ed
Update tests for getDefaultAccount
camden11 48cff29
Add tests for default account override
camden11 1b99a2b
Add tests for default account override
camden11 c413242
Clean some things up
camden11 6b5dd10
make sandboxAccountType deprecated
camden11 46f0b30
Fix casing bug
camden11 fec1d99
add getConfigAccountIfExists
camden11 fb7d46c
Update a lot of lib files
camden11 8e68f43
v0.2.0-experimental.0
camden11 78d8a03
Merge branch 'main' into dynamic-config
camden11 32433cd
add http use localhost config flag
camden11 61e2a1e
add getConfigDefaultAccountIfExists
camden11 a8c86af
Merge branch 'main' into dynamic-config
camden11 7eb31fc
Updateconfig migrate for revamped config
camden11 d8eab5f
remove unused copy
camden11 bcacccd
export getConfigAtPath
camden11 bbef362
Updateconfig merging logic
camden11 1b6e75b
Add tests for migrations
camden11 e17b8b2
Merge pull request #254 from HubSpot/dynamic-config-migrations
camden11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the existing content of the readme to reflect the changes I made, but it may make sense to rethink it completely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah good call. That could always be done as a follow up