Add support for importing reflection probes. #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reflection Probes import as empties, so a Light Probe object is added to host the component and then parented to the empty.
…importing textures so that any references to the textures return the correct image and don't fail. The previous behavior could cause index out of bounds errors when trying to access textures and their images.
…hat the rotation is properly applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflection Probes import as empties in the normal glTF import, but the Reflection Probe component is only valid on Light Probes. This PR changes it so that a Light Probe object with the correct location, rotation, and scale is added when importing the component and then parented to the empty. The component is then imported onto the new Light Probe object instead of the empty. No further parenting is attempted, so this should pose no danger to complex hierarchical relationships.
An issue with importing textures that I discovered when testing this PR has also been fixed.