Don't play audio after the loading screen has been hidden

Hubs-Foundation · May 23, 2023 · 266fd79 · 266fd79
1 parent 95c05fd
commit 266fd79
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/hub.js b/src/hub.js
@@ -574,10 +574,16 @@ function handleHubChannelJoined(entryManager, hubChannel, messageDispatch, data)
 
   console.log(`Dialog host: ${hub.host}:${hub.port}`);
 
+  const audioSystem = scene.systems["hubs-systems"].audioSystem;
+  audioSystem.setMasterVolume(0);
+
   remountUI({
     messageDispatch: messageDispatch,
     onSendMessage: messageDispatch.dispatch,
-    onLoaded: () => store.executeOnLoadActions(scene),
+    onLoaded: () => {
+      audioSystem.setMasterVolume(1);
+      store.executeOnLoadActions(scene);
+    },
     onMediaSearchResultEntrySelected: (entry, selectAction) =>
       scene.emit("action_selected_media_result_entry", { entry, selectAction }),
     onMediaSearchCancelled: entry => scene.emit("action_media_search_cancelled", entry),

diff --git a/src/systems/audio-system.js b/src/systems/audio-system.js
@@ -165,6 +165,10 @@ export class AudioSystem {
     window.APP.store.addEventListener("statechanged", this.onPrefsUpdated);
   }
 
+  setMasterVolume(vol) {
+    this._sceneEl.audioListener.setMasterVolume(vol);
+  }
+
   addStreamToOutboundAudio(id, mediaStream) {
     if (this.audioNodes.has(id)) {
       this.removeStreamFromOutboundAudio(id);