Skip to content

Commit

Permalink
fix: OPTIC-720: Fix e.viewsStore.forEach error (#5849)
Browse files Browse the repository at this point in the history
Hotfix after #5824

---------

Co-authored-by: robot-ci-heartex <[email protected]>
  • Loading branch information
2 people authored and jombooth committed May 8, 2024
1 parent 15ea962 commit 779ee98
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 16 deletions.
2 changes: 1 addition & 1 deletion web/dist/apps/labelstudio/main.js

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions web/dist/apps/labelstudio/version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"message": "fix: OPTIC-712: Remove warnings in the app related to injection occur before observer",
"commit": "9f1d0c707d44c452b223704aa11417b2ba3c039e",
"date": "2024-05-03T17:03:19.000Z",
"branch": "fb-optic-712/remove-warnings"
"message": "Revert #5824",
"commit": "c3ef6015499d27319533be5701ad23f105645ed0",
"date": "2024-05-08T13:08:10.000Z",
"branch": "fb-optic-720/viewsstore-foreach"
}
2 changes: 1 addition & 1 deletion web/dist/libs/datamanager/main.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion web/dist/libs/datamanager/main.js.map

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions web/dist/libs/datamanager/version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"message": "fix: OPTIC-712: Remove warnings in the app related to injection occur before observer",
"commit": "9f1d0c707d44c452b223704aa11417b2ba3c039e",
"date": "2024-05-03T17:03:19.000Z",
"branch": "fb-optic-712/remove-warnings"
"message": "Revert #5824",
"commit": "c3ef6015499d27319533be5701ad23f105645ed0",
"date": "2024-05-08T13:08:10.000Z",
"branch": "fb-optic-720/viewsstore-foreach"
}
8 changes: 4 additions & 4 deletions web/dist/libs/editor/version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"message": "fix: OPTIC-712: Remove warnings in the app related to injection occur before observer",
"commit": "9f1d0c707d44c452b223704aa11417b2ba3c039e",
"date": "2024-05-03T17:03:19.000Z",
"branch": "fb-optic-712/remove-warnings"
"message": "Revert #5824",
"commit": "c3ef6015499d27319533be5701ad23f105645ed0",
"date": "2024-05-08T13:08:10.000Z",
"branch": "fb-optic-720/viewsstore-foreach"
}
1 change: 0 additions & 1 deletion web/libs/datamanager/src/stores/AppStore.js
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ export const AppStore = types

beforeDestroy() {
clearTimeout(self._poll);
self.viewsStore.forEach((view) => view.destroy());
window.removeEventListener("popstate", self.handlePopState);
networkActivity.destroy();
},
Expand Down

0 comments on commit 779ee98

Please sign in to comment.