Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
…5788) - [x] Commit message(s) and PR title follows the format `[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made` ex. `fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors` - [x] Tests for the changes have been added/updated (for bug fixes/features) - [x] Docs have been added/updated (for bug fixes/features) - [x] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.) - [x] Self-reviewed and ran all changes on a local instance (for bug fixes/features) _(check all that apply)_ - [ ] Product design - [ ] Backend (Database) - [x] Backend (API) - [ ] Frontend _(link to issue, supportive screenshots etc.)_ #5787 _(if this is a bug fix)_ Updates `base.py` to search for `COLLECT_ANALYTICS` environment variable instead of `collect_analytics` _(if this is a breaking or feature change)_ _(if this is a breaking or feature change)_ _(list all with version changes)_ _(if so describe the impacts positive or negative)_ _(if so describe the impacts positive or negative)_ Positive: backend analytics are properly disabled when deploying with Helm. _(briefly list any if applicable)_ _(briefly list any if applicable)_ _(check only one)_ - [ ] Yes, and covered entirely by feature flag(s) - [ ] Yes, and covered partially by feature flag(s) - [ ] No - [x] Not sure (briefly explain the situation below) The environment variable name is changing to all upper-case - no impact if using Helm, as it enforces all caps. Other users who pass variables in with Docker Compose or other setup methods may already be using lower case, and their setup methods may not enforce all-caps. _(check all that apply)_ - [ ] e2e - [ ] integration - [x] unit _(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)_ Analytics / logging --------- Co-authored-by: Jo Booth <[email protected]>
- Loading branch information