feat: LEAP-1351: LSF customization for bulk annotation #6203

Gondragos · 2024-08-14T06:41:22Z

This PR adds

"annotation:bulk" interface that allows to hide all panels and elements that can't be set equally to group of annotaions
small fixes for custom controll buttons in bottom bar to be able to use them
fix the way we deliver config in cypress tests

PR fulfills these requirements

Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Tests for the changes have been added/updated (for bug fixes/features)
Docs have been added/updated (for bug fixes/features)
Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

Product design
Backend (Database)
Backend (API)
Frontend

What feature flags were used to cover this change?

fflag_feat_all_leap_1181_bulk_annotation_short

Does this PR introduce a breaking change?

Yes, and covered entirely by feature flag(s)
Yes, and covered partially by feature flag(s)
No
Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

e2e
integration
unit

Which logical domain(s) does this change affect?

Editor, BottomBar

- hide dependant controls - hide panels

- for bulk annotation mode displaying - for custom controls rendering and modify on fly - fix delivering the config from the cypress environment into the test environment

netlify · 2024-08-14T06:41:41Z

✅ Deploy Preview for label-studio-docs-new-theme canceled.

Name	Link
🔨 Latest commit	`bd5b0ed`
🔍 Latest deploy log	https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6740aef9336a6b0009d9535f

netlify · 2024-08-14T06:41:46Z

✅ Deploy Preview for heartex-docs canceled.

Name	Link
🔨 Latest commit	`bd5b0ed`
🔍 Latest deploy log	https://app.netlify.com/sites/heartex-docs/deploys/6740aef91d64800008b0330f

web/libs/editor/src/components/App/App.jsx

web/libs/editor/src/tags/visual/Collapse.jsx

web/libs/editor/src/tags/visual/Filter.jsx

hlomzik · 2024-08-14T11:42:09Z

Would not it be better to name interface "annotation:bulk"? That will keep it in a shape of namespace:detail like for lot of other interfaces. I know they are a mess but that's a really lowcost change on an early stage with small benefit

web/libs/editor/src/components/App/App.jsx

web/libs/editor/src/core/CustomTypes.ts

web/libs/editor/src/tags/visual/View.jsx

web/libs/editor/src/core/Tree.tsx

web/libs/editor/src/components/BottomBar/BottomBar.jsx

Separated bulk mode and independence checks into variables for readability. This makes the conditional logic clearer and potentially reduces redundancy in code review and debugging processes. No functional changes have been introduced.

# Conflicts: # web/libs/editor/src/components/BottomBar/BottomBar.jsx

Gondragos · 2024-08-26T15:21:56Z

/git merge develop

Workflow run
Successfully merged: Already up to date.

Gondragos · 2024-08-29T14:56:16Z

/git merge develop

Workflow run
Successfully merged: 387 files changed, 6483 insertions(+), 9039 deletions(-)

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/10617538191

Gondragos · 2024-09-02T23:20:23Z

/git merge develop

Workflow run
Successfully merged: 29 files changed, 94 insertions(+), 69 deletions(-)

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/10674028201

robot-ci-heartex · 2024-10-19T01:58:42Z

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

robot-ci-heartex · 2024-10-29T02:00:38Z

This PR was closed because it has been stalled for 10 days with no activity.

# Conflicts: # web/libs/editor/src/components/App/App.jsx # web/libs/editor/src/components/BottomBar/Controls.tsx # web/libs/editor/src/stores/AppStore.js # web/libs/editor/src/tags/control/ClassificationBase.js # web/libs/editor/src/tags/visual/Collapse.jsx # web/libs/editor/src/tags/visual/View.jsx

Gondragos · 2024-11-22T15:44:53Z

/git merge develop

Workflow run
Successfully merged: 29 files changed, 78 insertions(+), 117 deletions(-)

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/11975726292

…eartexlabs/label-studio into fb-leap-1351/bulk-annotation-lsf

Gondragos added 5 commits August 14, 2024 06:42

feat: LEAP-1351: LSF customization for bulk annotation

d7331f8

- hide dependant controls - hide panels

feat: LEAP-1351: Add ability to customize bottom bar control buttons

6593f92

tests: LEAP-1351: Add tests

16c2bb7

- for bulk annotation mode displaying - for custom controls rendering and modify on fly - fix delivering the config from the cypress environment into the test environment

Refactoring

224514b

Merge branch 'refs/heads/develop' into fb-leap-1351/bulk-annotation-lsf

9895956

github-actions bot added the feat label Aug 14, 2024

biome fixes

2b56bb6

yyassi-heartex reviewed Aug 14, 2024

View reviewed changes

web/libs/editor/src/components/App/App.jsx Outdated Show resolved Hide resolved

yyassi-heartex reviewed Aug 14, 2024

View reviewed changes

web/libs/editor/src/tags/visual/Collapse.jsx Outdated Show resolved Hide resolved

yyassi-heartex reviewed Aug 14, 2024

View reviewed changes

web/libs/editor/src/tags/visual/Filter.jsx Outdated Show resolved Hide resolved

Refactoring

e8e756e

Gondragos added 2 commits August 14, 2024 12:52

Rename interface

d989d4a

Hide unnecessary elements for both modes with outliner

73277b6

hlomzik reviewed Aug 14, 2024

View reviewed changes

web/libs/editor/src/components/App/App.jsx Outdated Show resolved Hide resolved

Gondragos added 3 commits August 14, 2024 15:07

Rename variable

0d0842b

Fix misprint

f74f9c0

Hide more things and update tests

f19a06f

hlomzik reviewed Aug 19, 2024

View reviewed changes

web/libs/editor/src/core/CustomTypes.ts Outdated Show resolved Hide resolved

hlomzik reviewed Aug 19, 2024

View reviewed changes

web/libs/editor/src/tags/visual/View.jsx Outdated Show resolved Hide resolved

hlomzik reviewed Aug 19, 2024

View reviewed changes

web/libs/editor/src/core/Tree.tsx Outdated Show resolved Hide resolved

hlomzik reviewed Aug 19, 2024

View reviewed changes

web/libs/editor/src/components/BottomBar/BottomBar.jsx Outdated Show resolved Hide resolved

hlomzik approved these changes Aug 19, 2024

View reviewed changes

Gondragos added 2 commits August 26, 2024 14:54

Refactor condition

f5336ed

Separated bulk mode and independence checks into variables for readability. This makes the conditional logic clearer and potentially reduces redundancy in code review and debugging processes. No functional changes have been introduced.

Merge branch 'develop' into fb-leap-1351/bulk-annotation-lsf

17cb58d

# Conflicts: # web/libs/editor/src/components/BottomBar/BottomBar.jsx

Merge branch 'develop' into 'fb-leap-1351/bulk-annotation-lsf'

6ea5746

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/10617538191

Merge branch 'develop' into 'fb-leap-1351/bulk-annotation-lsf'

8e51cea

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/10674028201

robot-ci-heartex added the Stale label Oct 19, 2024

robot-ci-heartex closed this Oct 29, 2024

Gondragos reopened this Nov 19, 2024

robot-ci-heartex removed the Stale label Nov 20, 2024

Gondragos added 4 commits November 20, 2024 14:59

Adjust types, small fixes, add ability to update button

f958929

Adjust tests

a1bb31d

Merge branch 'develop' into fb-leap-1351/bulk-annotation-lsf

d603916

Gondragos and others added 5 commits November 22, 2024 15:48

Merge branch 'develop' into 'fb-leap-1351/bulk-annotation-lsf'

46427e0

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/11975726292

Remove unused parts of code

1edc48a

Change way of applying state to CustomButton

0c6e6e4

Refactoring

5e95fbd

Merge branch 'fb-leap-1351/bulk-annotation-lsf' of ssh://github.com/h…

bd5b0ed

…eartexlabs/label-studio into fb-leap-1351/bulk-annotation-lsf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: LEAP-1351: LSF customization for bulk annotation #6203

feat: LEAP-1351: LSF customization for bulk annotation #6203

Gondragos commented Aug 14, 2024 •

edited

Loading

netlify bot commented Aug 14, 2024 •

edited

Loading

netlify bot commented Aug 14, 2024 •

edited

Loading

hlomzik commented Aug 14, 2024

Gondragos commented Aug 26, 2024 •

edited by robot-ci-heartex

Loading

Gondragos commented Aug 29, 2024 •

edited by robot-ci-heartex

Loading

Gondragos commented Sep 2, 2024 •

edited by robot-ci-heartex

Loading

robot-ci-heartex commented Oct 19, 2024

robot-ci-heartex commented Oct 29, 2024

Gondragos commented Nov 22, 2024 •

edited by robot-ci-heartex

Loading

feat: LEAP-1351: LSF customization for bulk annotation #6203

Are you sure you want to change the base?

feat: LEAP-1351: LSF customization for bulk annotation #6203

Conversation

Gondragos commented Aug 14, 2024 • edited Loading

PR fulfills these requirements

Change has impacts in these area(s)

What feature flags were used to cover this change?

Does this PR introduce a breaking change?

What level of testing was included in the change?

Which logical domain(s) does this change affect?

netlify bot commented Aug 14, 2024 • edited Loading

✅ Deploy Preview for label-studio-docs-new-theme canceled.

netlify bot commented Aug 14, 2024 • edited Loading

✅ Deploy Preview for heartex-docs canceled.

hlomzik commented Aug 14, 2024

Gondragos commented Aug 26, 2024 • edited by robot-ci-heartex Loading

Gondragos commented Aug 29, 2024 • edited by robot-ci-heartex Loading

Gondragos commented Sep 2, 2024 • edited by robot-ci-heartex Loading

robot-ci-heartex commented Oct 19, 2024

robot-ci-heartex commented Oct 29, 2024

Gondragos commented Nov 22, 2024 • edited by robot-ci-heartex Loading

Gondragos commented Aug 14, 2024 •

edited

Loading

netlify bot commented Aug 14, 2024 •

edited

Loading

netlify bot commented Aug 14, 2024 •

edited

Loading

Gondragos commented Aug 26, 2024 •

edited by robot-ci-heartex

Loading

Gondragos commented Aug 29, 2024 •

edited by robot-ci-heartex

Loading

Gondragos commented Sep 2, 2024 •

edited by robot-ci-heartex

Loading

Gondragos commented Nov 22, 2024 •

edited by robot-ci-heartex

Loading