Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: OPTIC-927: Remove Stale Feature Flag - ff_front_dev_2432_auto_save_polygon_draft_210622_short #6581

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Oct 30, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Removing a FF that was stale for a few months.

WHEN REVIEW
CHECK THE STALE VALUE FIRST

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit a9ef4d6
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6736089d1b95c10008c7818d

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit a9ef4d6
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6736089d8b60390008c238bf

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 45.94595% with 40 lines in your changes missing coverage. Please review.

Project coverage is 76.67%. Comparing base (fae09df) to head (a9ef4d6).
Report is 41 commits behind head on develop.

Files with missing lines Patch % Lines
..._studio/core/management/commands/locked_migrate.py 0.00% 30 Missing ⚠️
label_studio/core/label_config.py 73.91% 6 Missing ⚠️
label_studio/core/utils/common.py 66.66% 2 Missing ⚠️
label_studio/tasks/models.py 66.66% 1 Missing ⚠️
label_studio/users/models.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6581      +/-   ##
===========================================
- Coverage    76.72%   76.67%   -0.05%     
===========================================
  Files          169      169              
  Lines        13818    13846      +28     
===========================================
+ Hits         10602    10617      +15     
- Misses        3216     3229      +13     
Flag Coverage Δ
pytests 76.67% <45.94%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luarmr
Copy link
Contributor Author

luarmr commented Oct 31, 2024

Thanks @yyassi-heartex for pin point
#6584

@luarmr luarmr force-pushed the fb-optic-927/remove-stale-feature-flag---fffrontdev2432autosavepolygondraft210622short branch from 09b1355 to 36f5b8c Compare October 31, 2024 20:36
@luarmr
Copy link
Contributor Author

luarmr commented Nov 13, 2024

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/editor/src/components/SidePanels/DetailsPanel/TimelineRegionEditor.tsx

@luarmr luarmr force-pushed the fb-optic-927/remove-stale-feature-flag---fffrontdev2432autosavepolygondraft210622short branch from 6cd2cfc to 7aa9731 Compare November 14, 2024 01:10
luarmr and others added 4 commits November 13, 2024 17:28
…autosavepolygondraft210622short' of github.com:heartexlabs/label-studio into fb-optic-927/remove-stale-feature-flag---fffrontdev2432autosavepolygondraft210622short
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants