-
Notifications
You must be signed in to change notification settings - Fork 3.2k
refactor: ECHO-415: BEM Migration in editor #8660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 54 commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
53c775e
refactor(bem): replace Block with cn() in Space.tsx
luarmr a6fe3fe
refactor(bem): replace Block/Elem with cn() in ViewControls.tsx
luarmr 395a69d
refactor(bem): replace Block/Elem with cn() in GroundTruth.jsx
luarmr c493f9e
refactor(bem): replace Block/Elem with cn() in TimeBox.tsx
luarmr 19d4afd
refactor(bem): replace Block with cn() in TimeDurationControl.tsx
luarmr 352b668
refactor(bem): replace Block/Elem with cn() in Pagination.tsx
luarmr eb64bb9
refactor(bem): replace Block with cn() in Hint.tsx
luarmr e26ad61
refactor(bem): replace Block/Elem with cn() in Button.tsx
luarmr d1ddd85
refactor(bem): replace Block/Elem with cn() in Range.tsx
luarmr ec7126d
refactor(bem): replace Block with cn() in Icon.jsx
luarmr 80a76fd
refactor(bem): replace Block/Elem with cn() in AnnotationButton.tsx
luarmr c597898
refactor(bem): replace Block/Elem with cn() in AnnotationsCarousel.tsx
luarmr 6ae6e14
refactor(bem): replace Block/Elem with cn() in Label.jsx
luarmr 684a7c4
refactor(bem): replace Block with cn() in Menu.jsx
luarmr 2bc2f83
refactor(bem): replace Block with cn() in TaxonomySearch.tsx
luarmr 59d1e93
refactor(bem): replace Block/Elem with cn() in RelationsControls.tsx
luarmr d350deb
refactor(bem): replace Block/Elem with cn() in AutoAcceptToggle.jsx
luarmr 5e51952
refactor(bem): replace Block/Elem with cn() in DynamicPreannotationsT…
luarmr c55bcb5
refactor(bem): replace Block with cn() in DropdownComponent.tsx
luarmr e57d73d
refactor(bem): replace Block/Elem with cn() in Tool.jsx
luarmr aefc2ac
refactor(bem): replace Block/Elem with cn() in OutlinerPanel.tsx
luarmr 4488deb
refactor(bem): replace Block/Elem with cn() in AnnotationHistory.tsx
luarmr 02713be
refactor(bem): replace Block/Elem with cn() in OutlinerTree.tsx
luarmr 804f487
refactor(bem): replace Block/Elem with cn() in RegionLabel.tsx
luarmr cde33fc
refactor(bem): replace Block/Elem with cn() in Seeker.tsx
luarmr b58f9c9
refactor(bem): replace Block/Elem with cn() in Slider.tsx
luarmr cd835bc
refactor(bem): replace Block/Elem with cn() in ConfigControl.tsx
luarmr d6b4117
refactor(bem): replace Block/Elem with cn() in SpectrogramControl.tsx
luarmr 71ebcb2
refactor(bem): replace Block/Elem with cn() in AudioControl.tsx
luarmr b4b364a
refactor(bem): replace Block/Elem with cn() in AudioUltra ConfigContr…
luarmr 50f3493
refactor(bem): replace Block with cn() in FramesControl.tsx
luarmr 009ffef
refactor(bem): replace Block/Elem with cn() in Controls.tsx
luarmr 0162ab5
refactor(bem): replace Block/Elem with cn() in Timeline.tsx
luarmr a83b480
refactor(bem): replace Block/Elem with cn() in TopBar Controls.jsx
luarmr 1d2408c
refactor(bem): replace Block/Elem with cn() in TopBar.jsx
luarmr 95388b4
refactor(bem): replace Elem with cn() in Actions.jsx
luarmr 490b380
refactor(bem): replace Block/Elem with cn() in Annotations.jsx
luarmr 51bf772
refactor(bem): replace Block/Elem with cn() in CurrentTask.jsx
luarmr 43df286
refactor(bem): replace Block with cn() in HistoryActions.jsx
luarmr 505d22f
refactor(bem): replace Block/Elem with cn() in Toolbar.jsx
luarmr e6fc9ed
refactor(bem): replace Block/Elem with cn() in PanelBase.tsx
luarmr cc1c746
refactor(bem): replace Block/Elem with cn() in SidePanels.tsx
luarmr f1ea516
refactor(bem): replace Block/Elem with cn() in Hotkey.ts
luarmr 887e99f
refactor(bem): replace Block/Elem with cn() in FlyoutMenu.jsx
luarmr d34b772
refactor(bem): replace Block/Elem with cn() in Minimap.tsx
luarmr 43ca8f5
refactor(bem): replace Block/Elem with cn() in Frames.tsx
luarmr 7e064ca
refactor(bem): replace Block/Elem with cn() in Keypoints.tsx
luarmr e1deb13
refactor(bem): replace Block/Elem with cn() in Tabs.tsx
luarmr d6cba7c
refactor(bem): replace Block/Elem with cn() in PanelTabsBase.tsx
luarmr 07ae70b
refactor(bem): replace Block/Elem with cn() in SideTabsPanels.tsx
luarmr 7677baa
refactor(bem): replace Block with cn() in RegionLabels.tsx
luarmr fa89d86
refactor(bem): replace Block/Elem with cn() in RegionDetails.tsx
luarmr 64dcb99
refactor(bem): replace Block/Elem with cn() in Relations.tsx
luarmr a8dd6c8
refactor(bem): replace Block/Elem with cn() in RegionEditor.tsx
luarmr 0137cb8
refactor(bem): replace Block/Elem with cn() in RegionItem.tsx
luarmr c8cd118
refactor(bem): replace Block/Elem with cn() in DetailsPanel.tsx
luarmr d198a40
refactor(bem): replace Block/Elem with cn() in BottomBar.jsx and Acti…
luarmr 5cab075
refactor(bem): replace Block/Elem with cn() in BottomBar Controls.tsx
luarmr cde427c
refactor(bem): replace Block/Elem with cn() in BottomBar CurrentTask.jsx
luarmr b65a527
refactor(bem): replace Block/Elem with cn() in VideoCanvas.tsx and Im…
luarmr d09becc
refactor(bem): replace Block/Elem with cn() in AnnotationTabs.jsx and…
luarmr f01e20d
biome fixes and add explicit type="button" to Tool component
luarmr 9d8be84
test: update bem mocks to include cn() function in panel tests
luarmr d5a25ca
test: update test assertions after removing Block/Elem mocks
luarmr 2c121e1
useBem fixes
luarmr 58e7c0f
Merge branch 'develop' into 'fb-bemything'
luarmr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| import React from "react"; | ||
| import { Block } from "../../utils/bem"; | ||
| import { cn } from "../../utils/bem"; | ||
| import "./Icon.scss"; | ||
|
|
||
| export const Icon = React.forwardRef(({ icon, ...props }, ref) => { | ||
| return ( | ||
| <Block tag="span" name="icon" ref={ref}> | ||
| <span ref={ref} className={cn("icon").toClassName()}> | ||
| {React.createElement(icon, props)} | ||
| </Block> | ||
| </span> | ||
| ); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.