-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix: BROS-513: Vector can be drawn outside of canvas using the transform tool #8666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8666 +/- ##
===========================================
- Coverage 67.09% 59.45% -7.65%
===========================================
Files 792 554 -238
Lines 60394 39002 -21392
Branches 10290 10318 +28
===========================================
- Hits 40522 23187 -17335
+ Misses 19869 15812 -4057
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
if (constrainedBox.x < bounds.x) { | ||
const deltaX = bounds.x - constrainedBox.x; | ||
constrainedBox.x = bounds.x; | ||
constrainedBox.width = Math.max(10, constrainedBox.width - deltaX); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this magic number 10 to constant and check that it's consistent with other relevant places (creation? what else?)
This PR addresses the issue when a shape can be moved outside of the image bounds.