Skip to content

Conversation

nick-skriabin
Copy link
Member

This PR addresses the issue when a shape can be moved outside of the image bounds.

Copy link

netlify bot commented Oct 17, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit 9075b57
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/68f7bd890840390008d01eb8
😎 Deploy Preview https://deploy-preview-8666--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Oct 17, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit 9075b57
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/68f7bd8943b68e0008e0ab55
😎 Deploy Preview https://deploy-preview-8666--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Oct 17, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 9075b57
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/68f7bd891e35cc0008845af4

@github-actions github-actions bot added the fix label Oct 17, 2025
Copy link

netlify bot commented Oct 17, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 9075b57
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/68f7bd89fec6c40008d20df2

Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 0.54645% with 182 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.45%. Comparing base (5b459c8) to head (9075b57).
⚠️ Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
...src/components/KonvaVector/utils/boundsChecking.ts 0.00% 95 Missing ⚠️
...nents/KonvaVector/components/VectorTransformer.tsx 1.31% 75 Missing ⚠️
...src/components/KonvaVector/pointCreationManager.ts 0.00% 6 Missing ⚠️
...ponents/KonvaVector/eventHandlers/mouseHandlers.ts 0.00% 5 Missing ⚠️
...rc/components/KonvaVector/eventHandlers/drawing.ts 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5b459c8) and HEAD (9075b57). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5b459c8) HEAD (9075b57)
pytests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8666      +/-   ##
===========================================
- Coverage    67.09%   59.45%   -7.65%     
===========================================
  Files          792      554     -238     
  Lines        60394    39002   -21392     
  Branches     10290    10318      +28     
===========================================
- Hits         40522    23187   -17335     
+ Misses       19869    15812    -4057     
  Partials         3        3              
Flag Coverage Δ
lsf-e2e 52.84% <0.54%> (-1.54%) ⬇️
lsf-integration 50.62% <0.54%> (-0.17%) ⬇️
lsf-unit 8.36% <0.54%> (-0.04%) ⬇️
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

if (constrainedBox.x < bounds.x) {
const deltaX = bounds.x - constrainedBox.x;
constrainedBox.x = bounds.x;
constrainedBox.width = Math.max(10, constrainedBox.width - deltaX);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this magic number 10 to constant and check that it's consistent with other relevant places (creation? what else?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants