fix: BROS-655: Overview channels is not filtered by overvierChannels parameter.
#8948
Conversation
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #8948 +/- ##
===========================================
- Coverage 66.58% 57.74% -8.85%
===========================================
Files 828 561 -267
Lines 64570 40558 -24012
Branches 10984 10985 +1
===========================================
- Hits 42997 23421 -19576
+ Misses 21569 17133 -4436
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| .split(",") | ||
| .map((name) => { | ||
| const trimmed = name.trim(); | ||
| return /^\d+$/.test(trimmed) && item.headers ? item.headers[Number(trimmed)]?.toLowerCase() : trimmed; |
There was a problem hiding this comment.
Is item.headers always guaranteed to be an array?
There was a problem hiding this comment.
I'm assuming the fix here is more to do with the normalization of the keys that were likely not matching up in the repro cases?
There was a problem hiding this comment.
@hlomzik you should know better. i'm really new to timeseries
This PR addresses the issue where TimeSeries's
overviewChannelswon't take any effect on the overview channels panel.Fix demo:
timeseries.mp4
Refer to #8176