-
Notifications
You must be signed in to change notification settings - Fork 3.3k
refactor: FIT-1112: remove fflag_fix_front_leap_218_improve_performance_of_taxonomy_search_short #8972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8972 +/- ##
===========================================
- Coverage 66.70% 66.69% -0.01%
===========================================
Files 828 828
Lines 64762 64757 -5
Branches 10986 10982 -4
===========================================
- Hits 43198 43189 -9
- Misses 21560 21564 +4
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@hlomzik as you suggested offline, I went deeper in the removal |
…ce_of_taxonomy_search_short
70f4dc6 to
e3b4a0b
Compare
hlomzik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All great, but I'd make code a little more explicit
Co-authored-by: Andrew <[email protected]>
Cleanup fflag_fix_front_leap_218_improve_performance_of_taxonomy_search_short to value true, already in stale for a while