fix: FIT-1105: Missing FSM export state when FF is on #8990
+80
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-playground canceled.
|
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook canceled.
|
Comment on lines
+118
to
+120
| # Debug: Log what we're capturing | ||
| logger.info(f'_capture_context: captured context_data={context_data}') | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| # Debug: Log what we're capturing | |
| logger.info(f'_capture_context: captured context_data={context_data}') |
Comment on lines
+101
to
+105
|
|
||
| logger.info( | ||
| f'BaseExportDataSerializer: task_id={task.id}, state_in_ret={ret.get("state")}, ' | ||
| f'user={user}, user_id={getattr(user, "id", None)}, flag_568={flag_568}, flag_710={flag_710}' | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| logger.info( | |
| f'BaseExportDataSerializer: task_id={task.id}, state_in_ret={ret.get("state")}, ' | |
| f'user={user}, user_id={getattr(user, "id", None)}, flag_568={flag_568}, flag_710={flag_710}' | |
| ) |
Comment on lines
+79
to
+80
| logger = logging.getLogger(__name__) | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| logger = logging.getLogger(__name__) |
Comment on lines
+74
to
+75
| import logging | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| import logging |
yyassi-heartex
approved these changes
Dec 12, 2025
Contributor
yyassi-heartex
left a comment
yyassi-heartex
left a comment
There was a problem hiding this comment.
looks good, just clearing out some logging that looks to be there for debugging
Contributor
|
/git merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors how background jobs are started for file exports and storage synchronization by consolidating the logic into the
start_job_async_or_syncutility. This change ensures that context (like user and organization IDs) is consistently captured and restored, simplifies the code by removing repetitive Redis connection checks, and improves job tracking. The main updates are in the export and storage sync flows, making them more robust and easier to maintain.Refactoring and simplification of background job execution:
django_rqand manual Redis connection checks with thestart_job_async_or_syncutility inlabel_studio/data_export/mixins.pyandlabel_studio/io_storages/base_models.py, ensuring consistent context propagation and reducing code duplication. [1] [2] [3] [4] [5] [6]Job tracking and logging improvements:
Background job deduplication:
Context handling enhancements: