-
Notifications
You must be signed in to change notification settings - Fork 0
reference code for handle the scan result #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| .PHONY: zip | ||
|
|
||
| MKDIR := mkdir | ||
| ZIP := zip | ||
|
|
||
| zip: | ||
| $(MKDIR) -p zip | ||
| $(ZIP) zip/send-malware-to-sns.zip handler.py | ||
|
|
||
| create-target-sns-topic: | ||
| aws sns create-topic --name $(TARGET_SNS_TOPIC_NAME) | ||
|
|
||
| create-publish-malware-policy: | ||
| aws iam create-policy \ | ||
| --policy-name $(PUBLISH_MALWARE_POLICY_NAME) \ | ||
| --policy-document "{\"Version\":\"2012-10-17\",\"Statement\":[{\"Sid\":\"VisualEditor0\",\"Effect\":\"Allow\",\"Action\":[\"sns:TagResource\",\"sns:Publish\",\"account:GetAlternateContact\"],\"Resource\":\"*\"}]}" | ||
|
|
||
| create-publish-malware-role: | ||
| aws iam create-role \ | ||
| --role-name $(PUBLISH_MALWARE_ROLE_NAME) \ | ||
| --assume-role-policy-document "{\"Version\": \"2012-10-17\",\"Statement\": [{\"Action\": \"sts:AssumeRole\",\"Effect\": \"Allow\",\"Principal\": {\"Service\": \"lambda.amazonaws.com\"}}]}" | ||
|
|
||
| attach-policy: | ||
| aws iam attach-role-policy \ | ||
| --role-name $(PUBLISH_MALWARE_ROLE_NAME) \ | ||
| --policy-arn arn:aws:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole | ||
|
|
||
| aws iam attach-role-policy \ | ||
| --role-name $(PUBLISH_MALWARE_ROLE_NAME) \ | ||
| --policy-arn $(PUBLISH_MALWARE_POLICY_ARN) | ||
|
|
||
| create-function: zip | ||
| aws lambda create-function \ | ||
| --function-name $(PUBLISH_MALWARE_LAMBDA_NAME) \ | ||
| --role $(PUBLISH_MALWARE_ROLE_ARN) \ | ||
| --runtime python3.9 \ | ||
| --timeout 30 \ | ||
| --memory-size 128 \ | ||
| --handler handler.lambda_handler \ | ||
| --environment Variables=\{TARGET_SNS_ARN=$(TARGET_SNS_TOPIC_ARN)\} \ | ||
| --zip-file fileb://zip/send-malware-to-sns.zip | ||
|
|
||
| subscribe-to-sns-topic: | ||
| aws sns subscribe \ | ||
| --topic-arn $(SCAN_RESULT_TOPIC_ARN) \ | ||
| --protocol lambda \ | ||
| --notification-endpoint $(PUBLISH_MALWARE_LAMBDA_ARN) \ | ||
| --region $(REGION) | ||
|
|
||
| add-lambda-permission: | ||
| aws lambda add-permission \ | ||
| --function-name $(PUBLISH_MALWARE_LAMBDA_NAME) \ | ||
| --region $(REGION) \ | ||
| --statement-id sns \ | ||
| --action lambda:InvokeFunction \ | ||
| --principal sns.amazonaws.com \ | ||
| --source-arn $(SCAN_RESULT_TOPIC_ARN) | ||
|
|
||
| update-function-code: zip | ||
| aws lambda update-function-code \ | ||
| --function-name $(FUNCTION_NAME) \ | ||
| --zip-file fileb://zip/send-malware-to-sns.zip | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| # Cloud One File Storage Security Post Scan Action - Publish Malware to SNS Topic | ||
|
|
||
| After a scan occurs, this example Lambda function publish the malware information to specific SNS topic. | ||
|
|
||
| ## Prerequisites | ||
|
|
||
| ### Find the 'ScanResultTopicARN' SNS topic ARN | ||
|
|
||
| - In the AWS console, go to **Services > CloudFormation** > your all-in-one stack > **Outputs** or **Services > CloudFormation** > your storage stack > **Outputs**. | ||
| - Scroll down to locate the **ScanResultTopicARN** Key. | ||
| - Copy the **ScanResultTopic** ARN to a temporary location. Example: `arn:aws:sns:us-east-1:123445678901:FileStorageSecurity-All-In-One-Stack-StorageStack-1IDPU1PZ2W5RN-ScanResultTopic-N8DD2JH1GRKF` | ||
|
|
||
| ## Installation | ||
|
|
||
| ### From Cloudformation Template | ||
|
|
||
| 1. Visit AWS cloudformation console. | ||
| 2. Click **Create Stack**. | ||
| 3. Upload `template.yml` in this folder. | ||
| 4. Fill in the paramters. | ||
| 5. Click **Next**. | ||
| 6. Check the require access capabilities checkboxes. | ||
| 7. Click **Create Stack**. | ||
|
|
||
| ### From Makefile | ||
|
|
||
| In a shell program, enter the following GNU Make command, using backslashes (`\`) to separate lines | ||
|
|
||
| 1. **Create Malware Target SNS Topic** | ||
|
|
||
| ```bash | ||
| TARGET_SNS_TOPIC_NAME=<YOUR_TARGET_SNS_TOPIC_NAME> \ | ||
| make create-target-sns-topic | ||
| ``` | ||
|
|
||
| - where: | ||
| - `<YOUR_TARGET_SNS_TOPIC_NAME>` is the name for the new SNS topic which cloud be published the walmare information. | ||
|
|
||
| 2. **Create Required Policy** | ||
|
|
||
| ```bash | ||
| PUBLISH_MALWARE_POLICY_NAME=<YOUR_PUBLISH_MALWARE_POLICY_NAME> \ | ||
| make create-publish-malware-policy | ||
| ``` | ||
|
|
||
| - where | ||
| - `<YOUR_PUBLISH_MALWARE_POLICY_NAME>` is the name for the new policy. | ||
|
|
||
| 3. **Create Required Role** | ||
|
|
||
| ```bash | ||
| PUBLISH_MALWARE_POLICY_NAME=<YOUR_PUBLISH_MALWARE_ROLE_NAME> \ | ||
| make create-publish-malware-role | ||
| ``` | ||
|
|
||
| - where | ||
| - `<YOUR_PUBLISH_MALWARE_ROLE_NAME>` is the name for the new role. | ||
|
|
||
| 4. **Attach Policy** | ||
|
|
||
| ```bash | ||
| PUBLISH_MALWARE_ROLE_NAME=<YOUR_PUBLISH_MALWARE_ROLE_NAME> \ | ||
| PUBLISH_MALWARE_POLICY_ARN=<YOUR_PUBLISH_MALWARE_POLICY_ARN> \ | ||
| make create-publish-malware-role | ||
| ``` | ||
|
|
||
| - where | ||
| - `<YOUR_PUBLISH_MALWARE_POLICY_ARN>` is the policy ARN created from step 2. | ||
| - `<YOUR_PUBLISH_MALWARE_ROLE_NAME>` is the role name created from step 3. | ||
|
|
||
| 5. **Create Lambda Function** | ||
|
|
||
| ```bash | ||
| PUBLISH_MALWARE_LAMBDA_NAME=<YOUR_PUBLISH_MALWARE_LAMBDA_NAME> \ | ||
| PUBLISH_MALWARE_ROLE_ARN=<YOUR_PUBLISH_MALWARE_ROLE_ARN> \ | ||
| TARGET_SNS_TOPIC_ARN=<YOUR_TARGET_SNS_TOPIC_ARN> \ | ||
| make create-function | ||
| ``` | ||
|
|
||
| - where | ||
| - `<YOUR_TARGET_SNS_TOPIC_ARN>` is the SNS topic ARN created from step 1. | ||
| - `<YOUR_PUBLISH_MALWARE_ROLE_ARN>` is the role ARN created from step 3. | ||
| - `<YOUR_PUBLISH_MALWARE_LAMBDA_NAME>` is the name for new lambda function. | ||
|
|
||
| 6. **SNS Subscrition** | ||
|
|
||
| ```bash | ||
| SCAN_RESULT_TOPIC_ARN=<YOUR_SCAN_RESULT_TOPIC_ARN> \ | ||
| PUBLISH_MALWARE_LAMBDA_ARN=<YOUR_PUBLISH_MALWARE_LAMBDA_ARN> \ | ||
| REGION=<YOUR_REGION> \ | ||
| make subscribe-to-sns-topic | ||
| ``` | ||
|
|
||
| - where | ||
| - `<YOUR_PUBLISH_MALWARE_LAMBDA_ARN>` is the lambda function ARN created from step 5. | ||
| - `<YOUR_SCAN_RESULT_TOPIC_ARN>` is the SNS topic ARN from the storage stack. | ||
| - `<YOUR_REGION>` is the building AWS region. | ||
|
|
||
| 7. **Add Lambda Permission** | ||
|
|
||
| ```bash | ||
| PUBLISH_MALWARE_LAMBDA_NAME=<YOUR_PUBLISH_MALWARE_LAMBDA_NAME> \ | ||
| REGION=<YOUR_REGION> \ | ||
| SCAN_RESULT_TOPIC_ARN=<YOUR_SCAN_RESULT_TOPIC_ARN> \ | ||
| make add-lambda-permission | ||
| ``` | ||
|
|
||
| - where | ||
| - `<YOUR_PUBLISH_MALWARE_LAMBDA_NAME>` is the lambda function and created from step 5. | ||
| - `<YOUR_REGION>` is the building AWS region. | ||
| - `<SCAN_RESULT_TOPIC_ARN>` is the SNS topic ARN from the storage stack. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| import os | ||
| import json | ||
| from datetime import datetime | ||
| from urllib.parse import urlparse | ||
|
|
||
| import boto3 | ||
|
|
||
|
|
||
| def get_bucket_name(file_url): | ||
|
|
||
| url = urlparse(file_url) | ||
| return url.hostname.split('.')[0] | ||
|
|
||
|
|
||
| def get_iso_str(ts): | ||
|
|
||
| dt = datetime.fromtimestamp(ts) | ||
| return dt.isoformat() | ||
|
|
||
|
|
||
| def fetch_account_name(): | ||
|
|
||
| account_client = boto3.client('account') | ||
| response = account_client.get_alternate_contact( | ||
| AlternateContactType='SECURITY' | ||
| ) | ||
|
|
||
| return response['AlternateContact']['Name'] | ||
|
|
||
|
|
||
| def lambda_handler(event, context): | ||
|
|
||
| target_sns_arn = os.environ['TARGET_SNS_ARN'] | ||
|
|
||
| scan_results = [] | ||
|
|
||
| for record in event['Records']: | ||
|
|
||
| print('record', record) | ||
|
|
||
| # Message details from SNS event | ||
| message = json.loads(record['Sns']['Message']) | ||
| findings = message['scanning_result'].get('Findings') | ||
|
|
||
| # ARN info to get AWS Account ID | ||
| # arn = json.dumps(record['EventSubscriptionArn']) | ||
| # account_id = arn.split(":")[4].strip() | ||
Hundao marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| if not findings: | ||
| continue | ||
|
|
||
| finding = findings[0] | ||
|
|
||
| scan_results.append({ | ||
| 'bucket_name': get_bucket_name(message['file_url']), | ||
| 'account_name': fetch_account_name(), | ||
|
||
| 'malware_type': finding['malware'], | ||
Hundao marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| 'type': finding['type'], | ||
Hundao marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| 'time': get_iso_str(message['timestamp']) | ||
| }) | ||
|
|
||
| print('scan_results', scan_results) | ||
|
|
||
| sns_client = boto3.client('sns') | ||
| request_entries = [ | ||
| { | ||
| 'Message': json.dumps(scan_result), | ||
| 'Id': str(i) | ||
| } | ||
| for i, scan_result in enumerate(scan_results) | ||
| ] | ||
|
|
||
| response = sns_client.publish_batch( | ||
|
||
| TopicArn=target_sns_arn, | ||
| PublishBatchRequestEntries=request_entries, | ||
| ) | ||
|
|
||
| print(response) | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,90 @@ | ||||||||||||||
| AWSTemplateFormatVersion: 2010-09-09 | ||||||||||||||
| Transform: AWS::Serverless-2016-10-31 | ||||||||||||||
|
|
||||||||||||||
| Metadata: | ||||||||||||||
| AWS::ServerlessRepo::Application: | ||||||||||||||
| Name: cloudone-filestorage-plugin-publish-malware-to-sns | ||||||||||||||
| Description: >- | ||||||||||||||
| According to the scan result from the scanner, publish the malware information | ||||||||||||||
| to the target SNS topic. | ||||||||||||||
| Author: Trend Micro Cloud One File Storage Security | ||||||||||||||
|
||||||||||||||
|
|
||||||||||||||
| Parameters: | ||||||||||||||
| TargetSnsTopicName: | ||||||||||||||
| Type: String | ||||||||||||||
| Description: The name for the SNS topic to which malware information publish. | ||||||||||||||
|
||||||||||||||
| PublishMalwareLambdaName: | ||||||||||||||
| Type: String | ||||||||||||||
| Description: The name for the lambda function publishes the malware information to SNS topic. | ||||||||||||||
| PublishMalwarePolicyName: | ||||||||||||||
| Type: String | ||||||||||||||
| Description: The name for the policy includes sns and account authority. | ||||||||||||||
| PublishMalwareRoleName: | ||||||||||||||
| Type: String | ||||||||||||||
| Description: The name for the role to execute the lambda function. | ||||||||||||||
|
||||||||||||||
| ScanResultTopicARN: | ||||||||||||||
| Type: String | ||||||||||||||
| Description: The ARN of the scan result SNS topic in storage stack. | ||||||||||||||
| Resources: | ||||||||||||||
| TargetSnsTopic: | ||||||||||||||
| Type: AWS::SNS::Topic | ||||||||||||||
| Properties: | ||||||||||||||
| TopicName: !Ref TargetSnsTopicName | ||||||||||||||
| DisplayName: Malware notification | ||||||||||||||
| PublishMalwarePolicy: | ||||||||||||||
| Type: AWS::IAM::ManagedPolicy | ||||||||||||||
| Properties: | ||||||||||||||
| ManagedPolicyName: !Ref PublishMalwarePolicyName | ||||||||||||||
| PolicyDocument: | ||||||||||||||
| Version: "2012-10-17" | ||||||||||||||
| Statement: | ||||||||||||||
| - Effect: Allow | ||||||||||||||
| Action: | ||||||||||||||
| - 'sns:TagResource' | ||||||||||||||
| - 'sns:Publish' | ||||||||||||||
| - 'account:GetAlternateContact' | ||||||||||||||
|
||||||||||||||
| - 'sns:TagResource' | |
| - 'sns:Publish' | |
| - 'account:GetAlternateContact' | |
| - sns:TagResource | |
| - sns:Publish | |
| - account:GetAlternateContact |
And what's sns:TagResource for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sns:TagResource is redundant, I will remove it in next commit.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you choose the timeout for this Lambda?
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the endpoint of AWS eventbridge. Should be sns.amazonaws.com?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'm very confused for why I can't receive the notification from SNS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are not matched with ones in the template. Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will align them in the next commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The runtime is not aligned still.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the lost, fixed already.