Pallet error, UpdateBlockPacket not working

README.md

@@ -1,4 +1,9 @@
-#  <img src="https://lbsg.net/wp-content/themes/lifeboat/images/lbsg-logo-sm.png" alt="LBSG logo" title="Aimeos" align="center" height="120" />
+# DEPRECATED
+
+**Steadfast2 is no longer supported as of Minecraft: Bedrock Edition 1.19.70 and will receive no further updates.**
+
+Lifeboat Survival Games has now migrated to [PocketMine-MP](https://github.com/pmmp/PocketMine-MP).
+
 # Steadfast2 Minecraft PE Server Software
 
 ## Introduction

src/pocketmine/ChunkMaker.php

@@ -42,6 +42,7 @@ public function sendData($identifier, $buffer) {
 		$pk = new EncapsulatedPacket();
 		$pk->buffer = $buffer;
 		$pk->reliability = 3;
+		$pk->orderChannel = 0;
 		$enBuffer = chr(RakLib::PACKET_ENCAPSULATED) . chr(strlen($identifier)) . $identifier . chr(RakLib::PRIORITY_NORMAL) . $pk->toBinary(true);
 		$this->raklib->pushMainToThreadPacket($enBuffer);
 	}

src/pocketmine/ChunkStorage.php

@@ -2,16 +2,24 @@
 
 namespace pocketmine;
 
-use pocketmine\utils\Binary;
+use pocketmine\level\generator\biome\Biome;
+use pocketmine\level\Level;
 use pocketmine\network\protocol\FullChunkDataPacket;
 use pocketmine\network\protocol\Info;
-use pocketmine\level\Level;
+use pocketmine\utils\Binary;
+use function chr;
+use function count;
+use function implode;
 
 class ChunkStorage {
 
 	protected $cache = [];
+	/** @var ChunkMaker */
 	protected $server;
 
+	/**
+	 * @param ChunkMaker $server
+	 */
 	public function __construct($server) {
 		$this->server = $server;
 		$this->tickProcessor();
@@ -56,8 +64,21 @@ protected function sendFromCache($data) {
 
 	protected function doChunk($data) {
 		$protocol = $data['protocol'];
-		if (isset($data['isAnvil']) && $data['isAnvil'] == true) {
-			$chunkData = chr(count($data['chunk']['sections']));
+		$isAnvil = isset($data['isAnvil']) && $data['isAnvil'] == true;
+
+		$subChunkCount = $isAnvil ? count($data['chunk']['sections']) : 8;
+
+		$chunkData = "";
+
+		if($protocol >= Info::PROTOCOL_475){
+			//TODO: HACK! fill in fake subchunks to make up for the new negative space client-side
+			for($y = 0; $y < 4; $y++){
+				$subChunkCount++;
+				$chunkData .= chr(8); //subchunk version 8
+				$chunkData .= chr(0); //0 layers - client will treat this as all-air
+			}
+		}
+		if ($isAnvil) {
 			foreach ($data['chunk']['sections'] as $y => $sections) {
 				if ($sections['empty'] == true) {
 					$blockData = "\x00" . str_repeat("\x00", 6144);						
@@ -71,15 +92,11 @@ protected function doChunk($data) {
 					$chunkData .= $blockData;
 				}
 			}
-			if ($protocol < Info::PROTOCOL_360) {
-				$chunkData .= $data['chunk']['heightMap'];
-			}
-			$chunkData .= $data['chunk']['biomeColor'] . Binary::writeByte(0) . Binary::writeSignedVarInt(0) . implode('', $data['tiles']);
+			$biomes = $data["chunk"]["biomeColor"];
 		} else {
 			$blockIdArray = $data['blocks'];
 			$blockDataArray = $data['data'];
 			$countBlocksInChunk = 8;
-			$chunkData = chr($countBlocksInChunk);
 			for ($blockIndex = 0; $blockIndex < $countBlocksInChunk; $blockIndex++) {
 				$blockIdData = '';
 				$blockDataData = '';
@@ -91,13 +108,24 @@ protected function doChunk($data) {
 				$blockData = "\x00" . $blockIdData . $blockDataData;
 				$chunkData .= $blockData;
 			}
-			$chunkData .= $data['heightMap'] . $data['biomeColor'] . Binary::writeLInt(0) . implode('', $data['tiles']);
+			$biomes = $data["biomeColor"];
+		}
+		if($protocol >= Info::PROTOCOL_475){
+			$count = $protocol >= Info::PROTOCOL_503 ? 24 : 25;
+			for($i = 0; $i < $count; ++$i){
+				$chunkData .= chr(0); //fake biome palette - 0 bpb, non-persistent
+				$chunkData .= Binary::writeVarInt(Biome::PLAINS << 1); //fill plains for now
+			}
+		}else{
+			$chunkData .= $biomes;
 		}
+		$chunkData .= Binary::writeByte(0) . implode('', $data['tiles']);
 		$subClientId = $data['subClientId'];
 		$pk = new FullChunkDataPacket();
 		$pk->chunkX = $data['chunkX'];
 		$pk->chunkZ = $data['chunkZ'];
 		$pk->senderSubClientID = $subClientId;
+		$pk->subChunkCount = $subChunkCount;
 		$pk->data = $chunkData;
 		$pk->encode($protocol);
 		$buffer = $pk->getBuffer();
@@ -120,7 +148,7 @@ private function sortData($data) {
 				for ($z = $x; $z < $zM; $z += 16) {
 					$yM = $z + 4096;
 					for ($y = $z; $y < $yM; $y += 256) {
-						$result{$i} = $data{$y};
+						$result[$i] = $data[$y];
 						++$i;
 					}
 				}
@@ -139,10 +167,10 @@ private function sortHalfData($data) {
 					for ($y = 0; $y < 8; ++$y) {
 						$j = (($y << 8) | $zx);
 						$j80 = ($j | 0x80);
-						$i1 = ord($data{$j});
-						$i2 = ord($data{$j80});
-						$result{$i} = chr(($i2 << 4) | ($i1 & 0x0f));
-						$result{$i | 0x80} = chr(($i1 >> 4) | ($i2 & 0xf0));
+						$i1 = ord($data[$j]);
+						$i2 = ord($data[$j80]);
+						$result[$i] = chr(($i2 << 4) | ($i1 & 0x0f));
+						$result[$i | 0x80] = chr(($i1 >> 4) | ($i2 & 0xf0));
 						$i++;
 					}
 				}

src/pocketmine/PacketMaker.php

@@ -115,6 +115,7 @@ protected function sendData($identifier, $buffer) {
 		$pk = new EncapsulatedPacket();
 		$pk->buffer = $buffer;
 		$pk->reliability = 3;
+		$pk->orderChannel = 0;
 		$enBuffer = chr(RakLib::PACKET_ENCAPSULATED) . chr(strlen($identifier)) . $identifier . chr(RakLib::PRIORITY_NORMAL) . $pk->toBinary(true);
 		$this->raklib->pushMainToThreadPacket($enBuffer);
 	}