New notifications experience #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per post notifications and email digests are now controlled on a per group basis rather then globally New notification settings UI
apps/web/src/routes/UserSettings/NotificationSettingsTab/NotificationSettingsTab.js
Outdated
Show resolved
Hide resolved
| return ( | ||
| <MenuLink | ||
| to={itemUrl} | ||
| externalLink={item?.customView?.type === "externalLink" ? item.customView.externalLink : null} | ||
| className="text-base text-foreground border-2 border-foreground/20 hover:border-foreground/100 hover:text-foreground rounded-md p-2 bg-background text-foreground mb-[.5rem] w-full transition-all scale-100 hover:scale-105 opacity-85 hover:opacity-100 flex align-items justify-between" | ||
| externalLink={item?.customView?.type === 'externalLink' ? item.customView.externalLink : null} |
There was a problem hiding this comment.
In general, I plan to go over all of this and double-check if things can be refractored from aarons changes
There was a problem hiding this comment.
yeah, I was going to go over better use of MenuLink with him at some point too
lorenjohnson
requested changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per post notifications and email digests are now controlled on a per group basis rather then globally
New notification settings UI