Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Circleci monorepo setup #25

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Conversation

lorenjohnson
Copy link
Member

No description provided.

@lorenjohnson lorenjohnson changed the title Circleci monorepo setup WIP: Circleci monorepo setup Oct 26, 2024
@lorenjohnson lorenjohnson changed the base branch from main to urql-poc October 26, 2024 00:29
@brodeur
Copy link
Contributor

brodeur commented Oct 26, 2024 via email

@lorenjohnson lorenjohnson changed the base branch from urql-poc to dev October 26, 2024 00:30
@lorenjohnson lorenjohnson force-pushed the circleci-monorepo-setup branch 2 times, most recently from 9b79ebc to 254ae5a Compare October 26, 2024 04:20
@lorenjohnson lorenjohnson force-pushed the circleci-monorepo-setup branch from 254ae5a to 345ae77 Compare October 26, 2024 04:24
@Hylozoic Hylozoic deleted a comment from gitguardian bot Oct 26, 2024
Copy link

gitguardian bot commented Oct 26, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
397097 Triggered Generic Password 345ae77 .circleci/continue_config.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@lorenjohnson
Copy link
Member Author

Alert!

All good

Alert!

On Fri, Oct 25, 2024 at 5:28 PM gitguardian[bot] @.> wrote: ⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request. Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components. 🔎 Detected hardcoded secret in your pull request GitGuardian id GitGuardian status Secret Commit Filename 14047417 https://dashboard.gitguardian.com/workspace/11872/incidents/14047417?occurrence=169204093 Triggered Generic Password 4e3ffe6 <4e3ffe6> docker-compose.yml View secret <4e3ffe6#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3R7> 🛠 Guidelines to remediate hardcoded secrets 1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. Learn here https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment the best practices. 3. Revoke and rotate this secret https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment . 4. If possible, rewrite git history https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these best practices https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment for managing and storing secrets including API keys and other credentials - install secret detection on pre-commit https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment to catch secret before it leaves your machine and ease remediation. ------------------------------ 🦉 GitGuardian https://dashboard.gitguardian.com/auth/login/?utm_medium=checkruns&utm_source=github&utm_campaign=cr1 detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. — Reply to this email directly, view it on GitHub <#25 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAULVHGT7RSXBKBYZBU563Z5LO37AVCNFSM6AAAAABQUHU23SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZZGA4DAOBVGQ . You are receiving this because you are subscribed to this thread.Message ID: @.>

Noted. It's not a real password, but it will probably move into our CircleCI env var config in a bit anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants