Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial project structure #3

Merged
merged 18 commits into from
May 28, 2024
Merged

Initial project structure #3

merged 18 commits into from
May 28, 2024

Conversation

Codestech1
Copy link
Member

@Codestech1 Codestech1 commented May 27, 2024

Adds an initial gradle project and packet structure.

@Codestech1 Codestech1 self-assigned this May 27, 2024
@Codestech1 Codestech1 marked this pull request as ready for review May 27, 2024 15:37
Window5000
Window5000 previously approved these changes May 27, 2024
@Codestech1 Codestech1 marked this pull request as draft May 28, 2024 05:47
@Codestech1
Copy link
Member Author

Modifying this pull request to create a non-breaking API via interfaces

@Codestech1
Copy link
Member Author

Serializing NBT text components is not possible for now, because kyori has not a serializer for them yet.
KyoriPowered/adventure#995

@Codestech1 Codestech1 marked this pull request as ready for review May 28, 2024 09:32
@Window5000
Copy link
Member

We should create an event system and integrate it with the packet system before merging, ie. the Packet class should extend Event.

Small thing:
if fx. B Event extends A event, then when B is called it should also call A event

@Window5000
Copy link
Member

ie calling an event should also call its parents

@Codestech1
Copy link
Member Author

We should create an event system and integrate it with the packet system before merging, ie. the Packet class should extend Event.

Small thing: if fx. B Event extends A event, then when B is called it should also call A event

The goal for now was achieving a working connection between server and client and a basic packet system.
Wouldn't it be better to make an event system in another PR?

@Window5000
Copy link
Member

well fx. the requeststatus packet will call an event, which will send an respondstatus packet instead of it comming directly from the other packet

@Codestech1
Copy link
Member Author

well fx. the requeststatus packet will call an event, which will send an respondstatus packet instead of it comming directly from the other packet

I could start making an event system now, but in another PR.

@Codestech1 Codestech1 added this to the 1.0 milestone May 28, 2024
@Codestech1 Codestech1 merged commit 81ac3c5 into ver/1.0 May 28, 2024
@Codestech1 Codestech1 deleted the initial-structure branch May 28, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants