feat: implement sanctifier ci one-shot command - #1292
Closed
bbkenny wants to merge 2 commits into
Closed
Conversation
|
@bbkenny is attempting to deploy a commit to the gbangbolaoluwagbemiga's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #807
Summary of Changes:
Implemented the
sanctifier cisubcommand to serve as the canonical entry point for Continuous Integration gates. This ensures that CI environments have a standardized, unified command for running analysis pipelines, resolving previous inconsistencies in CI gating.What changed:
tooling/sanctifier-cli/src/main.rs: Added thecisubcommand to the CLI parser.tooling/sanctifier-cli/src/ci.rs: Implemented the execution logic for thecicommand, integrating it with the underlying analysis engine.tooling/sanctifier-core/src/config.rs: Addressed minor upstream formatting and destructuring forSanctifyConfigto support the CI workflow correctly.tooling/sanctifier-core/src/noir_parser.rs: Fixed tuple destructuring warnings and collapsed nested conditions for cleaner AST parsing.tooling/sanctifier-core/src/smt/circuit_range.rs&zk_verifier_skippable.rs: Resolved unused imports, dead code warnings, and fixed unresolved Z3Asttrait method calls (_eq,ite) to ensure the CI pipeline compiles cleanly under strict linting (-D warnings).Testing / Local Verification:
cargo clippy --fix -p sanctifier-coreto resolve all linting warnings.cargo fmt -p sanctifier-coreto ensure strict formatting compliance.cargo check -p sanctifier-coreand verified that the build succeeds with 0 errors and 0 warnings.sanctifier cisubcommand triggers the correct execution path locally.