Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions S003_IMPLEMENTATION_SUMMARY.md
Original file line number Diff line number Diff line change
Expand Up @@ -353,13 +353,6 @@ FindingCode {
3. Update `docs/rules/s003-arithmetic-overflow.md`
4. Add fixture example to `s003_arithmetic.rs`

### Modifying Behavior

1. Update unit tests to reflect new behavior
2. Regenerate SARIF snapshots: `cargo insta review`
3. Update integration tests in `lib.rs`
4. Document change in `docs/rules/s003-arithmetic-overflow.md` Changelog
5. Consider schema versioning if JSON format changes

### Testing Checklist

Expand All @@ -369,6 +362,15 @@ FindingCode {
- [ ] SARIF snapshot matches: `cargo insta test`
- [ ] Documentation updated: Review `docs/rules/s003-arithmetic-overflow.md`

### Modifying Behavior

1. Update unit tests to reflect new behavior
2. Regenerate SARIF snapshots: `cargo insta review`
3. Update integration tests in `lib.rs`
4. Document change in `docs/rules/s003-arithmetic-overflow.md` Changelog
5. Consider schema versioning if JSON format changes


## Related Work

### Cross-References
Expand Down
12 changes: 7 additions & 5 deletions S012_IMPLEMENTATION_COMPLETE.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,19 @@ Successfully hardened the S012 (SEP-41 token interface compliance) checker in `t
- Usage examples and safety considerations
- Clear contribution guidelines

**Rule Documentation:**
- Complete rule guide at `docs/rules/s012-sep41-interface.md` (431 lines)
- Examples for all three issue types
- Remediation guidance and reference implementations
- Cross-references to related checks


**Reference Implementation:**
- Production-ready example at `examples/sep41-compliant-token.rs` (317 lines)
- Demonstrates all 10 SEP-41 functions correctly
- Extensive inline comments explaining compliance

**Rule Documentation:**
- Complete rule guide at `docs/rules/s012-sep41-interface.md` (431 lines)
- Examples for all three issue types
- Remediation guidance and reference implementations
- Cross-references to related checks

### ✅ Tests Added (Unit + Integration)

**Unit Tests** (existing):
Expand Down
Loading