Mh randutils #234
Draft
Mh randutils #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
It is rather strange to have a main function in the library. Is there any reason for this? It can create a name conflict |
|
Yes, that will be changed. Currently we're discussing how to best preserve the usage examples. |
cossorzano
requested changes
Mar 16, 2020
| * Example program using new RandUtils | ||
| */ | ||
|
|
||
| int main() { |
There was a problem hiding this comment.
Having a main in a library can cause a lot of troubles
|
A possibility that we have used is to add a big comment to the class including the usage. See for instance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API for random number generation. It uses new C++ library random functions.