Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Wiener filter in pytorch #812

Draft
wants to merge 19 commits into
base: devel
Choose a base branch
from
Draft

Conversation

oierlauzi
Copy link
Collaborator

@oierlauzi oierlauzi commented Sep 6, 2023

I have implemented a reduced version of xmipp_ctf_correct_wiener_2d in pytorch. The main advantage of this program is that it can make use of GPU acceleration, achieving significant performance improvements.

@oierlauzi oierlauzi marked this pull request as ready for review September 6, 2023 14:51
albertmena
albertmena previously approved these changes Sep 7, 2023
@albertmena
Copy link
Collaborator

@erneyramirez could you check if the code works as it should?

@erneyramirez
Copy link
Contributor

erneyramirez commented Sep 7, 2023

I have detected a difference in the output compared to "normal" Xmipp MRCs. I also think that the extension should be changed to .mrcs instead of .mrc, as the latter is typically used for volumes and not image stacks.

oier = mrcfile.mmap('oier.mrcs')
oier.data[0].shape
(1, 180,180)

xmipp = mrcfile.mmap('xmipp.mrcs')
xmipp.data[0].shape
(180,180)

oier.data.shape
(87603, 1, 128, 128)
xmipp.data.shape
(87603, 128, 128)

@oierlauzi
Copy link
Collaborator Author

Thank you Erney. Fixed it in the last commit

@erneyramirez
Copy link
Contributor

It's giving an error

@oierlauzi
Copy link
Collaborator Author

Fixed it

@albertmena albertmena marked this pull request as draft September 15, 2023 06:06
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 77 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 77 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
52 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Sep 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants