Add player reconnecting using name #343
Conversation
I3uckwheat
requested review from
aplyd,
wise-king-sullyman,
twalton83,
fortypercenttitanium and
sher-s7
and removed request for
aplyd and
wise-king-sullyman
There was a problem hiding this comment.
Following the steps on how to test, everything seems to work perfectly 👌
I'm not sure if this is out of scope, but if one player submits their cards and another player leaves, it looks like it puts the game in an unplayable state. If the same player joins back again, it still remains unplayable
chrome_XUS14gEGXa_Trim.mp4
|
@sher-s7 This is definitely an issue. Is this something that can be fixed on the host side by skipping the round? |
@I3uckwheat When I ran into the issue that was the first thing that came to mind. I think it might be a good solution |
if a player has not submitted, disconnects, and reconnects, the game would hang.
|
@sher-s7 I've updated the code, it should have some things rounded out now. |
0. Make sure your issue is linked:
Closes: #333
Mentions: #344
1. Purpose:
To allow clients to reconnect if they have accidentally disconnected
2. Implementation:
Remove the logic that removes a card from the Czar's hand and adjust the player ID when they reconnect.
The reconnect is simply using the player name. This also allows for changing devices mid-game.
3. Possible Issues:
There are missing tests for the re-connection of players.
There could be a specific edge case around players reconnecting at the same time the Czar selects
It is unknown what happens when the Czar disconnects currently.
4. How to Test:
Start a game with 3 players
select cards
disconnect a player
reconnect the player
czar selects cards
ensure that all winners are valid.
Try different combinations of disconnecting and reconnecting.
5. Cleanup
console.logs