Repository navigation
Add --format json to CLI commands #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dhruv8sh
wants to merge
13
commits into
main
Choose a base branch
from
spec/383-cli-format-json
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,413
−436
Open
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
09c7bf5
Add machine-readable CLI output spec
dhruv8sh c74d707
Add --format json to CLI commands
dhruv8sh ee94a6a
Merge branch 'main' into spec/383-cli-format-json
aram356 12ed8fc
Update --format json spec for the PR #388 review
dhruv8sh 9b8c710
Add plan recording the PR #388 review fixes
dhruv8sh cc6f1ac
Fix --format json results from the PR #388 review
dhruv8sh 082168c
Merge branch 'main' into spec/383-cli-format-json
prk-Jr e6a0b12
Address the second PR #388 review
dhruv8sh 392546a
Merge main into spec/383-cli-format-json
dhruv8sh daa1028
Merge branch 'main' into spec/383-cli-format-json
prk-Jr a8af11d
Merge branch 'main' into spec/383-cli-format-json
aram356 be91017
Address the third and fourth PR #388 reviews
dhruv8sh 8e0075a
Merge branch 'main' into spec/383-cli-format-json
prk-Jr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 [P1] Isolate the request-fidelity runner from the new Clippy rules
The standalone
request-fidelity-runnerinherits these rules, which reject its legitimate process calls and stdout report writer. Its required CI command fails with five diagnostics, blocking the workspace CI job. This reproduces locally on Rust 1.98.1 and matches the failed CI job.Proposed correction: add a fixture-local
clippy.toml, followingtests/fixtures/reusable-app/clippy.toml. Pointing Clippy at a temporary copy of that configuration makes the exact failing command pass.