Skip to content

Modernize UI for server side examples and differentiate tables #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eiman-eltigani-ttd merged 8 commits into from
Dec 9, 2025
Merged

Modernize UI for server side examples and differentiate tables #137

eiman-eltigani-ttd merged 8 commits into from
Dec 9, 2025

Conversation

@eiman-eltigani-ttd
Copy link
Contributor

@eiman-eltigani-ttd eiman-eltigani-ttd commented Dec 4, 2025 •
edited
Loading

See below for screenshots with the following changes:

  • Moved the button towards the top in the intro and made sure all intros included source code link
  • Created a new section for prebid (which contains the Prebid Token Storage key) and Google Secure Signals (which contains Secure Signals Loaded? and Secure Signals Value + ad) + Added a summary sentence since
  • Note: I didn't include pictures of the plain js-sdk because nothing changed beside moving the button
  • Additional clean up: Consilidated the server-side samples sites into one html file to be consistent with the other sites)

@eiman-eltigani-ttd eiman-eltigani-ttd changed the title Eee UI d2 5808 modernize UI for server side examples Modernize UI for server side examples and differentiate tables Dec 4, 2025
@eiman-eltigani-ttd
Copy link
Contributor Author

eiman-eltigani-ttd commented Dec 4, 2025 •
edited
Loading

Updated Prebid.js example
image

@eiman-eltigani-ttd
Copy link
Contributor Author

eiman-eltigani-ttd commented Dec 4, 2025 •
edited
Loading

Google Secure Signals example
image

@eiman-eltigani-ttd eiman-eltigani-ttd marked this pull request as ready for review December 4, 2025 16:04
ashleysmithTTD
ashleysmithTTD reviewed Dec 5, 2025
View reviewed changes
web-integrations/google-secure-signals/react-client-side/src/SecureSignalsApp.tsx Outdated
<span className="tooltip-trigger">?</span>
<div className="tooltip-content">
The encrypted {IDENTITY_NAME} token passed to Google Secure Signals for advertising. It is automatically refreshed by the SDK in the background when expired.
The encrypted {IDENTITY_NAME} token that is passed to ad systems without exposing raw user identity. It is automatically refreshed by the SDK in the background when expired.
Copy link
Contributor

@ashleysmithTTD ashleysmithTTD Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the definition before was better since it was more specific. or you could say "Google Ad Manager" too instead of "Google Secure Signals"

@eiman-eltigani-ttd eiman-eltigani-ttd merged commit a515bdd into main Dec 9, 2025
2 checks passed
@eiman-eltigani-ttd eiman-eltigani-ttd deleted the eee-UID2-5808-modernize-ui-for-server-side-examples branch December 9, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashleysmithTTD ashleysmithTTD ashleysmithTTD approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eiman-eltigani-ttd @ashleysmithTTD