Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cloud manager secret #79

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Added cloud manager secret #79

merged 3 commits into from
Dec 5, 2023

Conversation

perryan-coder
Copy link
Collaborator

No description provided.

@perryan
Copy link
Contributor

perryan commented Oct 19, 2023

I had initially thought to leave the original secret as being either a client_credential or a password grant_type, and have the cm stuff as completely separate, but it is sort of hybrid at the moment.
If non-cm secret is also a password the cm stuff won't work.
I wasn't sure if we needed the duality for the existing secret, or if we could state client_credentials only, which would simplify the code.
I submitted the review so we could have the discussion about best approach.

Copy link
Member

@rickymoorhouse rickymoorhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perryan-coder perryan-coder merged commit 1247191 into main Dec 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants