Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apiconnect.ibm.com apiGroups to clusterrole #81

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

alexisph
Copy link
Contributor

The trawler serviceAccount must be allowed get and list for the following, in order for the apiconnect overview metrics to be scraped:

- apiGroups: ["management.apiconnect.ibm.com"]
  resources: ["managementclusters"]
  verbs: ["get","list"]
- apiGroups: ["analytics.apiconnect.ibm.com"]
  resources: ["analyticsclusters"]
  verbs: ["get","list"]
- apiGroups: ["gateway.apiconnect.ibm.com"]
  resources: ["gatewayclusters"]
  verbs: ["get","list"]
- apiGroups: ["portal.apiconnect.ibm.com"]
  resources: ["portalclusters"]
  verbs: ["get","list"]

Copy link
Member

@rickymoorhouse rickymoorhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch thanks!

@rickymoorhouse
Copy link
Member

Would you please update the commit to be signed off so as to meet the DCO?

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name [email protected] in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

perryan and others added 4 commits January 11, 2024 15:03
Signed-off-by: Andrew Perry <[email protected]>
Signed-off-by: Alexandros Phinikarides <[email protected]>
Signed-off-by: Andrew Perry <[email protected]>
Signed-off-by: Alexandros Phinikarides <[email protected]>
Signed-off-by: Andrew Perry <[email protected]>
Signed-off-by: Alexandros Phinikarides <[email protected]>
Signed-off-by: Alexandros Phinikarides <[email protected]>
@alexisph
Copy link
Contributor Author

Would you please update the commit to be signed off so as to meet the DCO?

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name [email protected] in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Done

@rickymoorhouse rickymoorhouse merged commit 6361248 into IBM:main Jan 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants