AppConfigurationClient as a trait + IBMCloud implementation
#34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier G. Sogo <[email protected]>
jgsogo
commented
Dec 16, 2024
Comment on lines
-32
to
-38
| /// App Configuration client for browsing, and evaluating features and | ||
| /// properties. | ||
| #[derive(Debug)] | ||
| pub struct AppConfigurationClient { | ||
| pub(crate) latest_config_snapshot: Arc<Mutex<ConfigurationSnapshot>>, | ||
| pub(crate) _thread_terminator: std::sync::mpsc::Sender<()>, | ||
| } |
There was a problem hiding this comment.
All of this, and the implementation, has been moved to src/client/app_configuration_ibm_cloud.rs. There are no actual changes.
Signed-off-by: Javier G. Sogo <[email protected]>
Signed-off-by: Javier G. Sogo <[email protected]>
atilag
approved these changes
Dec 17, 2024
yoshiemuranaka
previously approved these changes
Dec 17, 2024
Signed-off-by: Javier G. Sogo <[email protected]>
jgsogo
force-pushed
the
feat/constructor
branch
from
fa2bc62 to
b2e158a
Compare
yoshiemuranaka
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31, but using a more idiomatic approach (for the complexity we have right now):
AppConfigurationClienttrait, andAppConfigurationClientIBMCloudimplementationSee #32 for more details and discarded alternatives