Support multiple keys/filesets for a bucket using export map #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: badri-pathak <[email protected]>
Signed-off-by: badri-pathak <[email protected]>
|
|
badri-pathak
requested review from
amdabhad,
hemalathagajendran and
deeghuge
Signed-off-by: badri-pathak <[email protected]>
Signed-off-by: badri-pathak <[email protected]>
amdabhad
reviewed
Sep 12, 2024
| return nil | ||
| } | ||
|
|
||
| func (s *SpectrumRestV2) CreateS3CacheFileset(ctx context.Context, filesystemName string, filesetName string, mode string, opts map[string]interface{}, bucketInfo map[string]string, exportMapName string, parsedEndpointURL *url.URL) error { |
There was a problem hiding this comment.
Is this tested with at least 2 cache volumes using 2 different set of keys (e.g. one with readOnly and other with readWrite access) for a single bucket? the read/write access to bucket should be as per the keys
There was a problem hiding this comment.
As mentioned by Badri, this will be covered by @saurabhwani5 during testing
amdabhad
reviewed
Sep 12, 2024
…or cache volume Signed-off-by: badri-pathak <[email protected]>
Signed-off-by: badri-pathak <[email protected]>
Signed-off-by: badri-pathak <[email protected]>
Signed-off-by: badri-pathak <[email protected]>
|
Image: quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:afmCacheExportMap_v26 |
Signed-off-by: badri-pathak <[email protected]>
Signed-off-by: badri-pathak <[email protected]>
|
New image with cosKeys deletion issue: quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:afmCacheExportMap_v27 |
Signed-off-by: badri-pathak <[email protected]>
|
The issue https://github.ibm.com/IBMSpectrumScale/scale-core/issues/7765 has been fixed. |
Signed-off-by: badri-pathak <[email protected]>
amdabhad
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
What is the new behavior?
How risky is this change?