Skip to content

Fix async token creation #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix async token creation #1116

wants to merge 3 commits into from

Conversation

nmveeresh
Copy link
Collaborator

@nmveeresh nmveeresh commented Sep 25, 2025 •
edited
Loading

Description

Updates the auth.py router to correctly await the asynchronous create_access_token(user) function during login.

Changes

File: mcpgateway/routers/auth.py

# Before
access_token, expires_in = create_access_token(user)

# After
access_token, expires_in = await create_access_token(user)

@nmveeresh nmveeresh marked this pull request as ready for review September 25, 2025 10:11
@crivetimihai
Copy link
Member

Hello, can you please check on the PR - the description and changes don't match.

@nmveeresh
Copy link
Collaborator Author

Changed PR tittle and description accordingly.

@nmveeresh nmveeresh changed the title Revert fast-time-server image tag to 0.7.0 Fix async token creation Sep 25, 2025
crivetimihai
crivetimihai reviewed Sep 27, 2025
View reviewed changes
Copy link
Member

@crivetimihai crivetimihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already fixed in main, closing. Thanks for the PR & testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crivetimihai crivetimihai crivetimihai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmveeresh @crivetimihai @calculus-ask