test: fix environment variable tests to verify actual values #1331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes environment variable tests in
test_translate_stdio_endpoint.pythat were not properly verifying that environment variables were actually set in the subprocess.Changes
_read_output()helper method to read subprocess output via pubsub subscriptiontest_start_with_initial_env_varstest_start_with_additional_env_varstest_environment_variable_overridetest_multiple_env_varstest_env_vars_with_special_characterstest_large_env_varsos.environ.copy()intest_multiple_env_varsTest Plan
All 21 tests pass successfully.
Impact
Tests now properly validate that environment variables are correctly passed to and set in the subprocess, rather than just checking that the process started.