Fixes iframe embedding blocked by DENY default #1345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shoumi <[email protected]>
Signed-off-by: Shoumi <[email protected]>
Signed-off-by: Shoumi <[email protected]>
shoummu1
requested review from
crivetimihai,
kevalmahajan and
madhav165
as code owners
This reverts commit 60c9df0.
This reverts commit 7849ea7.
This reverts commit 56ab705.
Signed-off-by: Shoumi <[email protected]>
This reverts commit 7849ea7. Signed-off-by: Shoumi <[email protected]>
This reverts commit 56ab705. Signed-off-by: Shoumi <[email protected]>
Signed-off-by: Shoumi <[email protected]>
…cp-context-forge into fix/iframe-options-default
This reverts commit 56ab705. Signed-off-by: Shoumi <[email protected]>
Signed-off-by: Shoumi <[email protected]>
…cp-context-forge into fix/iframe-options-default
|
Added a new PR to address this issue: PR 1352 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug-fix PR
📌 Summary
Fixes iframe embedding by properly handling empty X_FRAME_OPTIONS environment variable override in Docker deployments.
🔗 Related Issue
#1327
🐞Root Cause
Middleware falsy check ignored X_FRAME_OPTIONS="" environment variable, preventing iframe embedding configuration.
🧪 Verification
✅ Empty X_FRAME_OPTIONS="" now disables X-Frame-Options header
✅ Environment variables properly override default
✅ Docker compatibility confirmed
✅ Checklist
☑️ Code formatted
☑️ No breaking changes to MCP clients