Skip to content

Conversation

@madhav165
Copy link
Collaborator

🐛 Bug-fix PR


📌 Summary

Uses settings.pagination_default_page_size for limiting the results in server page.

Exploring options for the following fixes

  1. Consolidating multiple listing functions - list_tools, list_tools_for_user, etc.
  2. Using cursor instead of limit and offset for pagination in tools page to improve performance
  3. Adding pagination UI for tool selection for servers
  4. Making Select All work with paginated tools

🧪 Verification

Check Command Status
Lint suite make lint pass
Unit tests make test pass

📐 MCP Compliance (if relevant)

  • Matches current MCP spec
  • No breaking change to MCP clients

✅ Checklist

  • Code formatted (make black isort pre-commit)
  • No secrets/credentials committed

Signed-off-by: Madhav Kandukuri <[email protected]>
@madhav165 madhav165 self-assigned this Oct 27, 2025
Signed-off-by: Madhav Kandukuri <[email protected]>
@crivetimihai crivetimihai merged commit e48a695 into main Oct 27, 2025
45 checks passed
@crivetimihai crivetimihai deleted the temp-fix-pagination branch October 27, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants