-
Notifications
You must be signed in to change notification settings - Fork 458
Feature/qr code server #1652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cafalchio
wants to merge
100
commits into
IBM:main
Choose a base branch
from
cafalchio:feature/qr-code-server
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/qr code server #1652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Removed extra comments
-Added info when loaded
-Removed wrong validation
- implement create_qr - implemented simple happy path unit test
- Added base64 output
- Added error handling
- Added png, svg and ascii formats
- Added tests to cover generator changes
- It will check if user input has filename on it
- check if filename.ext has the correct ext
- It creates the output folder if it does not exist
- save method added to allow use as qrcode image
- Uses qrcode image factory to generate images
- Removed ascii logic from generator
- improved output path handling
- remove code used to run locally
- test for multiple formats PNG, SVG, ASCII
- test for error handling
- test create qr base64
Added a server test to list tools
…anage the following cases
- case 1: output_path is a folder
- case 2: output_path has file extension
- case 3: output_path has filename without extension
- case 4: output_path does not have filename
- Decoupled qr image generation from the create_qr_code
- Improved Ascii save to handle BytesIO for batch zip generation
- Handle errors
- Added tests to get 100% coverage
- Test manually to check created files
- changed ascii filename to have extension ascii
- Created a image generator to handle batch
- handled errors
- changed ascii format to have ascii extension
- Fixed ascii not encoding in base64
- Added validation to BatchQRgeneration
- Fixed lint
- loads from file image
- loads from base64
- load multiple types
- Fixed config not loading default values
…/mcp-context-forge into feature/qr-code-server
- Added Log when successfull
- added log for success false
…/mcp-context-forge into feature/qr-code-server
Author
|
Address issue #919 |
Member
|
Very cool. Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a MCP Server in Python that provides QR code generation and decoding capabilities. - closes #919
Server Details
mcp-servers/python/qr_code_server/generate_qr_code: Generate QR codes from text or datadecode_qr_code: Decode QR codes from image filesgenerate_batch_qr_codes: Generate multiple QR codes efficientlyvalidate_qr_data: Validate and analyze QR code data before generationTesting
Documentation
Checklist