-
Notifications
You must be signed in to change notification settings - Fork 1
EAGLE-1522: set 'strictNullChecks' flag in Typescript config #994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
james-strauss-uwa
wants to merge
22
commits into
master
Choose a base branch
from
eagle-1522
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @james-strauss-uwa, your pull request is larger than the review limit of 150000 diff characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the 'strictNullChecks' flag to 'true' in the Typescript config
This required changes to almost all Typescript files, to make sure we handle all cases where variables are null or undefined.
Significant changes:
Setting.findValue()is now a generic, so we can specify the type we expect to be returned. For example:Setting.findValue<string>(Setting.DOCKER_HUB_USERNAME, "")will return a string. Also notice that we now specify a default value, in case the Setting is undefined.Setting.find(X).setValue(y)can now be done withSetting.setValue(X, y)Translator.DEFAULT_TRANSLATION_ALGORITHMis now defined"alg-1".getParent()) return null if nothing is set. Some functions (e.g.findNodeById()) return undefined is the object can't be found. This could still use improvement.Node.clear(),Edge.clear()andField.clear()were unused and removedGraphRenderer.position2dtype to use everywhere we use {x:number, y:number}Setting.validValueTypestype (string | number | boolean) that specifies the type that may be stored in Settings