Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tpoignonec optionnal cmd msg + other features #3

Merged
merged 10 commits into from
Nov 9, 2023

Conversation

tpoignonec
Copy link
Member

Feature:

  • Optionnal command msg
  • Make ROS2 control period variable available to the python logic
  • Use parameter interface_full_namesinstead of jointsand interface_name:
<controller_name>
  ros__parameters:
    joints:
      - joint_1
      - joint_2
    interface_name:
      - velocity

becomes

<controller_name>
  ros__parameters:
    interface_full_names:
      - joint_1/velocity
      - joint_2/velocity

which allows for mixed/custom interface types (e.g., useful for force sensors)

  • CMake monitoring of the script

@tpoignonec tpoignonec requested a review from mcbed November 9, 2023 15:05
Copy link
Member

@mcbed mcbed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@mcbed mcbed merged commit 4c5aabb into main Nov 9, 2023
2 checks passed
@mcbed mcbed deleted the tpoignonec-optionnal_cmd_msg branch November 9, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants