Patching PR309 - #319
Open
jennirinker wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All description and motivation are clearly written by @RRiva in #309 .
I needed to make some small patches on top of Riccardo's changes and mistakenly created/pushed this branch to do so. (whoops) I will open this PR and close the original one, with a note referencing here.
@gbarter Feel free to merge this PR whenever you are ready to do so. It's approved from my side.
EDIT: Actually, Garrett, I see there are several tests failing now. But I don't understand how that could be, since we just changed a few controller parameters here. Is there something else I should add to this PR?