Making converter a cmd line script instead of a file that must be edited to be used#172
Making converter a cmd line script instead of a file that must be edited to be used#172ptrbortolotti merged 3 commits intomainfrom
Conversation
|
@fzahle - Not sure what is tripping up the docs build. Let me know if you want me to dig into that. Did you set that up originally or was that Rafael? |
|
Just fwiw if you configure the |
Great point and reminder. Yes, we do this in WISDEM for a couple scripts. It is a level up on user intrusiveness though, so I'll defer to @kenloen and other keepers of the WindIO to decide if they want to go that route. I would be happy to put in the necessary changes. |
|
I think it would be great to elevate the converter CLI tool that @gbarter added to a CLI tool of windIO like @rafmudaf suggest. The exact API for it could potentially be discuss (e.g. should the both the converter and validator be exposed as CLI tools?!). But in the interest of just adding it for now I guess we can just flag as a beta version and that the API might change in the future? |
|
Sounds good! I have added a |
|
@kenloen - Good to merge here? |
kenloen
left a comment
There was a problem hiding this comment.
Looks good!
Sorry for not getting back before.
fzahle
left a comment
There was a problem hiding this comment.
looks like the docs build CI test fails, maybe that's some of the stuff I tinkered with, so probably something I have to fix...
I think @ptrbortolotti was able to fix that in #178 . . . |
|
ah yes. so if you can just cherry-pick that commit, then we can merge |
Previously, the windio v1->2 converter had to be edited in the
if __name__==__main__section with the path to the input file. These changes make the converter a command line script where the usage is:The script is also now executable and can be called from the command line without the
pythonpreface if desired.