Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Navbar - Daisy UI Drawer #162

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Vignaraj-pai
Copy link
Contributor

@Vignaraj-pai Vignaraj-pai commented Aug 8, 2024

Description

Navbar - v0

  • Refactor Navbar with Daisy UI Navbar + Drawer component.
  • Refactor typescript effect to resolve z-index issue.
  • navbar styles for responsive logo sizes

Fixes # (issue)
#107 (partial)

  • Dropdown of menu items need to be handled (show only one at a time, clicking on another will hide any open dropdowns)
  • Navbar Data needs to be abstracted out of HTML into a simpler format and then processed by jinja.

Dependencies

None

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@anirudhprabhakaran3
Copy link
Member

LGTM!

@anirudhprabhakaran3 anirudhprabhakaran3 merged commit b8fed3d into IEEE-NITK:main Aug 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants